Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of Thompson MP cloud effective radii calculation #30

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented Jun 2, 2020

Changes in this PR:

  • physics/mp_thompson.{F90,meta}: cleanup use of optional arguments for cloud effective radii
  • physics/GFS_rrtmg_pre.F90: cleanup calculation of cloud effective radii, fix bugs

Associated PRs:
#30
NOAA-GSL/fv3atm#31
NOAA-GSL/ufs-weather-model#24

For regression testing information, see NOAA-GSL/ufs-weather-model#24.

Copy link
Collaborator

@tanyasmirnova tanyasmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in PR #30 look good to me.

@climbfuji
Copy link
Author

The changes in PR #30 look good to me.

Thanks, Tanya. I would like to run the C768 test that we ran for the previous commit to check for the differences. Need to wait for hera. Then, after cleaning up the progcld/unicloud logic in a next step, we should rerun the retrospectives.

@tanyasmirnova
Copy link
Collaborator

Sounds good, Dom.

@DomHeinzeller DomHeinzeller merged commit 02bdecf into NOAA-GSL:gsd/develop Jun 3, 2020
@climbfuji climbfuji deleted the thompson_mp_cloud_effective_radii_cleanup branch June 27, 2022 03:25
zhanglikate pushed a commit to zhanglikate/ccpp-physics that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants