The change gets around snow initialization with the use of RUC LSM #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added lat/lon to the parameter list for debugging purposes. 2. Flag_restart is replaced with lsm_cold_start. 3. Removed snow initialization with the use of RUC LSM. In case of cold start snow on land andice is initialized in io/FV3GFS_io.F90. In case of warm start, these variables are carried along. 3. Corresponding changes in GFS_surface_composites.meta.
tanyasmirnova
requested review from
SamuelTrahanNOAA,
christinaholtNOAA,
joeolson42,
hannahcbarnes,
mdtoyNOAA,
haiqinli and
zhanglikate
as code owners
This was referenced Mar 17, 2022
SamuelTrahanNOAA
approved these changes
Mar 17, 2022
hannahcbarnes
approved these changes
Mar 18, 2022
haiqinli
approved these changes
Mar 18, 2022
SamuelTrahanNOAA
added
bug
mdtoyNOAA
approved these changes
Mar 18, 2022
zhanglikate
pushed a commit
to zhanglikate/ccpp-physics
that referenced
this pull request
Mar 1, 2024
clm lake fix: pressure is not density + NOAA-GSL#142 and NOAA-GSL#148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start snow on land andice is initialized in io/FV3GFS_io.F90. In case of
warm start, these variables are carried along.