HAILCAST bug fix (units issue) #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensonr
approved these changes
Feb 15, 2024
|
@junwang-noaa Could you help move this one along? Is fixing an issue for RRFS. Thanks! |
junwang-noaa
approved these changes
Mar 1, 2024
|
@bensonr would you please commit the PR? Thanks |
haiqinli
added a commit
to haiqinli/GFDL_atmos_cubed_sphere
that referenced
this pull request
Mar 5, 2024
MatthewPyle-NOAA
pushed a commit
to NOAA-EMC/GFDL_atmos_cubed_sphere
that referenced
this pull request
Mar 19, 2024
… (unit issue) (NOAA-GFDL#320) (#87) * "include the bugfix in the HAILCAST diagnostic code (unit issue) (NOAA-GFDL#320)" * "to output the average of smoke and dust"
6 tasks
zhanglikate
added a commit
to zhanglikate/GFDL_atmos_cubed_sphere
that referenced
this pull request
Apr 30, 2024
commit 9711488 Author: Rusty Benson <[email protected]> Date: Wed Apr 17 08:41:41 2024 -0400 Address compiler warnings for FV3 raised in an issue (NOAA-GFDL#324) * give istatus a value on exit from hailcast_init * fix issues with declared out variables in test_cases.F90 * fix out of range default integers, eol spaces, and remove delz argument from set_regional_BCs in fv_regional_bc.F90 * removed -nowarn from Intel compiler flags * added suggested ifdef to remove goto warning as per operations commit 0301022 Author: Samuel Trahan (NOAA contractor) <[email protected]> Date: Fri Apr 12 20:02:26 2024 -0400 nesting bug fixes for uninitialized variable in fv3 and incorrect tile number in fv3atm (NOAA-GFDL#331) * pass global tile up to model * bug fix: initialize hailwat variable commit f060e85 Author: Jaymes Kenyon <[email protected]> Date: Fri Mar 1 22:23:31 2024 -0500 Correct a bug in the HAILCAST diagnostic code (units issue) (NOAA-GFDL#320)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This corrects a units issue in the HAILCAST diagnostic code. Prior to this fix, the diagnosed hail diameter was labeled in millimeters, but the calculated values (in the output) were actually in meters. This created the perception of very small hail, often just a fraction of a millimeter. The corrected code yields hail diameter in millimeters. Thanks to @adams-selin (HAILCAST developer) for the troubleshooting assistance and the bug fix.
How Has This Been Tested?
This modification has been tested on Hera in a 36-h RRFS retrospective case (CONUS domain). As expected, the diagnosed hail diameters are simply increased by a factor of 1000. As an example, a screenshot is attached of the "hailcast_dhail" array: previous values are shown at left, with updated (corrected) values on the right.
Checklist:
Please check all whether they apply or not