Resolves #269. Any variable that was named pos is now named domain_position

[thomas-robinson]

Description
All variables in the diag_manager named pos have been renamed domain_position
Requires updates to atmos_cubed_sphere

Fixes # (issue)
#269

How Has This Been Tested?
passed travis CI checks

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• New check tests, if applicable, are included
• make distcheck passes

[thomas-robinson]

@ngs333 is listed as a code owner in the CODEOWNERS file, but he was not assigned as a reviewer.

[underwoo]

@ngs333 is listed as a code owner in the CODEOWNERS file, but he was not assigned as a reviewer.

I think that is b/c @ngs333 hasn't accepted the invite to be a member of the NOAA-GFDL organization. It appears, from the codeowners documentation, that only team members will be assigned as reviewers.

[underwoo]

All looks good. Please let all the liaisons know of this change (we do need a change log document somewhere) as this will affect all components.

[thomas-robinson]

We are making the appropriate changes in NOAA-GFDL/GFDL_atmos_cubed_sphere#15 . We should probably wait to merge until that is complete. I know @nikizadehgfdl was also looking at using this functionality somewhere in the ice model.

[underwoo]

Please add something in the CHANGELOG.md file (under the unreleased section) to indicate this change. We need to start adding brief descriptions of changes in that file, and verify the information is included before performing a merge. I'll get something that will update the PR template to include a checkbox.

…

-- Seth Underwood S/W Development Process Lead Modeling Systems Group GFDL/NOAA/DOC 201 Forrestal Road Princeton, NJ 08540-6649 (609) 452-5847 Office (304) 376-9002 Cell (609) 987-5063 Fax [email protected]

On Thu, Jan 30, 2020 at 2:36 PM Tom Robinson ***@***.***> wrote: We are making the appropriate changes in NOAA-GFDL/GFDL_atmos_cubed_sphere#15 <NOAA-GFDL/GFDL_atmos_cubed_sphere#15> . We should probably wait to merge until that is complete. I know @nikizadehgfdl <https://github.com/nikizadehgfdl> was also looking at using this functionality somewhere in the ice model. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#270?email_source=notifications&email_token=AADJUSYCN5QHBDZNZKPPRG3RAMT4LA5CNFSM4KN2OJX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKMH2RA#issuecomment-580418884>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADJUS72MFI6Z4ER5H4XUGLRAMT4LANCNFSM4KN2OJXQ> .

[bensonr]

With coordination, I can merge NOAA-GFDL/GFDL_atmos_cubed_sphere#15 at the same time this PR is merged.

[wrongkindofdoctor]

@bensonr @thomas-robinson I will merge it in as soon as you confirm.

[bensonr]

@bensonr is ready when @thomas-robinson and @laurenchilutti confirm

[thomas-robinson]

@bensonr i think NOAA-GFDL/GFDL_atmos_cubed_sphere#14 need to come first so that all of the xanadu-tagged code works together. Then NOAA-GFDL/GFDL_atmos_cubed_sphere#15 should be merged after.

[bensonr]

@thomas-robinson I will do both at the same time.

[thomas-robinson]

@underwoo I updated the change log.