Remove multi-grid wave support #3188

AntonMFernando-NOAA · 2024-12-20T20:59:11Z

Description

Eliminate instances where waveGRD is a list containing multiple supported wave grids. Also, remove the associated for loops (e.g., for wavGRD in ${waveGRD}; do)
Resolves Remove multi-grid wave support #2637

Type of change

Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO
Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
- EMC verif-global
- GDAS
- GFS-utils
- GSI
- GSI-monitor
- GSI-utils
- UFS-utils
- UFS-weather-model
- wxflow

How has this been tested?

CI tests with HERA and HERCULES

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have documented my code, including function, input, and output descriptions
My changes generate no new warnings
New and existing tests pass with my changes

…nando-NOAA/global-workflow into feature/remove_waveGRD

ush/parsing_namelists_WW3.sh

parm/config/gfs/config.wave

aerorahul

Please see comments in the review.

This PR removes the waveMULTIGRID boolean option that enabled single/multiple wave grids defined under the variable waveGRD.
The scripts using this are split into if-else blocks. The elseblocks for a single grid waveMULTIGRID=.false. are very simple. However, the workflow has been exercising and developing on the if block of waveMULTIGRID=.true. even for cases where waveGRD is a single grid.
This PR rectifies that.
Careful examination and review is needed and appreciated from the wave experts to ensure the changes introduced in this PR does not impact (negatively) the wave grid operations.

Apart from a few suggestions, this PR looks good. Approve pending till after the wave team has a chance to review and approve the changes proposed in this PR.

ush/forecast_postdet.sh

ush/parsing_namelists_WW3.sh

sbanihash

Changes look good. Thank you @AntonMFernando-NOAA for your work on this. I have no comments on the changes, but would appreciate checking the wave history+products with this change before approving. Is there a test case you could share with me? If not I can make a quick test myself.

AntonMFernando-NOAA · 2024-12-24T17:34:13Z

Changes look good. Thank you @AntonMFernando-NOAA for your work on this. I have no comments on the changes, but would appreciate checking the wave history+products with this change before approving. Is there a test case you could share with me? If not I can make a quick test myself.

@sbanihash Test cases are here at HERA.
gfs: /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/EXPDIR/gfs_rw2
gefs: /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/EXPDIR/gefs_rw

sbanihash

Wave outputs and history files look good. I approve this PR.
edit: I have noticed that you have added a path to gefs testing as well, but the global-workflow directories used for gfs & gefs do not seem to be the same. I did do a diff and the differences seem to be unrelated to the changes made in this PR.

KateFriedman-NOAA · 2025-01-07T02:03:09Z

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3188/RUNTESTS on WCOSS

KateFriedman-NOAA · 2025-01-07T02:14:16Z

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3188/RUNTESTS on WCOSS

KateFriedman-NOAA · 2025-01-07T05:01:34Z

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3188/RUNTESTS on WCOSS

aerorahul · 2025-01-07T15:18:25Z

@JessicaMeixner-NOAA @sbanihash
Any final comments before we merge this PR after the WCOSS2 test finishes? (It likely will not since there was a production switch, @KateFriedman-NOAA you might have to either restart or bypass it) Would still like your final approvals now that Hera and Hercules tests have passed

aerorahul

lgtm

sbanihash

Changes look good. Thank you @AntonMFernando-NOAA for your work on this. Thank you @JessicaMeixner-NOAA for also reviewing the changes.

* develop: Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246) Add domain level to wave gridded COM path (NOAA-EMC#3137) CI JJOB Tests using CMake (NOAA-EMC#3214) Make assorted updates to waves (NOAA-EMC#3190) Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236) Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211) Add additional GEFS variables needed for AI/ML applications (NOAA-EMC#3221) Add bmat task dependency to marine LETKF task (NOAA-EMC#3224) Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229) Reinstate product groups (NOAA-EMC#3208) Additional fixes for downstream jobs (NOAA-EMC#3187) Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215) Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220) Update upload-artifact to v4 (NOAA-EMC#3216) Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217) Update g-w to cycle with C1152 ATM (NOAA-EMC#3206) Separate use of initial increment/perturbation file from REPLAY/+03 ICs (NOAA-EMC#3119) Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207) Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212) Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146) Remove multi-grid wave support (NOAA-EMC#3188) Add echgres as a dependency for earc (NOAA-EMC#3202)

* develop: Remove WAFS files and references from `develop` (NOAA-EMC#3263) fix intel stack version number on c5 (NOAA-EMC#3258) Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252) Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255) Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235) Only run METplus in the 3Dvar tests (NOAA-EMC#3245) Clone, build, and run C48_ATM and C48_S2SW on Gaea C5 and C6 (NOAA-EMC#3106) Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246) Add domain level to wave gridded COM path (NOAA-EMC#3137) CI JJOB Tests using CMake (NOAA-EMC#3214) Make assorted updates to waves (NOAA-EMC#3190) Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236) Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211) Add additional GEFS variables needed for AI/ML applications (NOAA-EMC#3221) Add bmat task dependency to marine LETKF task (NOAA-EMC#3224) Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229) Reinstate product groups (NOAA-EMC#3208) Additional fixes for downstream jobs (NOAA-EMC#3187) Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215) Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220) Update upload-artifact to v4 (NOAA-EMC#3216) Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217) Update g-w to cycle with C1152 ATM (NOAA-EMC#3206) Separate use of initial increment/perturbation file from REPLAY/+03 ICs (NOAA-EMC#3119) Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207) Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212) Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146) Remove multi-grid wave support (NOAA-EMC#3188) Add echgres as a dependency for earc (NOAA-EMC#3202) Ensure OCNRES and ICERES have 3 digits in the archive script (NOAA-EMC#3199) Set runtime shell requirements within Jenkins Pipeline (NOAA-EMC#3171) Add efcs and epos to ufs_hybatm xml (NOAA-EMC#3192) (NOAA-EMC#3193) Fix GEFS and SFS compile flags in build_all.sh (NOAA-EMC#3197) Remove early-cycle EnKF forecast (NOAA-EMC#3185) Fix mod_icec bug in atmos_prod (NOAA-EMC#3167) Create compute build option (NOAA-EMC#3186) Support global-workflow using Rocky 8 on CSPs (NOAA-EMC#2998) Change orog gravity wave drag scheme for grid sizes less than 10km (NOAA-EMC#3175) Switch snow DA to use 2DVar for deterministic and ensemble mean (NOAA-EMC#3163) Update compression options for GEFS history files (NOAA-EMC#3184) Update compression options for high res history files (NOAA-EMC#3178) Turn DO_TEST_MODE off (NOAA-EMC#3177) Hotfix for gdas_arch div/0 (NOAA-EMC#3169) Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow (NOAA-EMC#3098) Switch Aerosol DA to use JCB and Jedi class (NOAA-EMC#3125) Update ufs-weather-model to 2024-12-06 commit (NOAA-EMC#3145) Enable traditional threading as an option (NOAA-EMC#3149) Update HPC_ACCOUNT on Hercules to fv3-cpu (NOAA-EMC#3164) Turn C96C48_ufs_hybatmDA and C48mx500_3DVarAOWCDA into a regression test (NOAA-EMC#3120) Update GSI analysis jobs to use COMIN/COMOUT (NOAA-EMC#3092) Update HPC Tier Definitions (NOAA-EMC#3138) Add marine hybrid envar (NOAA-EMC#3041) Archive the experiment directory along with git status/diff output (NOAA-EMC#3105) Use stochastic restart patterns on rerun (NOAA-EMC#3077) Point Jenkinsfile back to CI/ (NOAA-EMC#3139) Fix wave restart for cold start and add ic version file (NOAA-EMC#3112) Allow users to override the default account at setup time (NOAA-EMC#3127) Refactor gridded wave post (NOAA-EMC#3014) Update docs related to NOAA CSPs (NOAA-EMC#3043) Allow APP to differ between RUNs (NOAA-EMC#2943) Run one executable for soca2cice (instead of two) (NOAA-EMC#3118) Speed up GSI analysis jobs in CI testing (NOAA-EMC#3115) Make aerosol output frequency variable (NOAA-EMC#2982) Add new stations to GFS BUFR sounding products (NOAA-EMC#3107) JCB-based obs+bias staging, Jedi class updates, and marine B-matrix refactoring (NOAA-EMC#2992) Enable tapering of atm ens perts at the model top (NOAA-EMC#3097) Update JGDAS ENKF POST job (NOAA-EMC#3090) SFS Runs at C96mx100 (NOAA-EMC#2960) Move machine-based options from config.base to host files (NOAA-EMC#3053) Remove RUNDIRS before running CI cases to cover re-run events (NOAA-EMC#3076) CI GitHub pipeline (hotfix) update for fetching repo name (NOAA-EMC#3084) Update JGDAS ENKF ECEN job (NOAA-EMC#3050) Update snow obs processing job (NOAA-EMC#3055) Update to action workflow pipeline in default repo for development (NOAA-EMC#3062) Update to action workflow pipeline in default repo for development (NOAA-EMC#3061) Update workflow pipeline (NOAA-EMC#3060) PW CI pipeline update5 ready for review so it can be merged and tested (NOAA-EMC#3059) Revert "GitHub CI Pipeline update for debugging forked PR support" (NOAA-EMC#3057) GitHub CI Pipeline update for debugging forked PR support (NOAA-EMC#3056) Add more ocean variables for post-processing in GEFS (NOAA-EMC#2995) Auto provisioning of PW clusters from GitHub CI added (NOAA-EMC#3051) Fix the name of the TC tracker filenames in archive.py (NOAA-EMC#3030) Make wxflow links static instead of from link_workflow (NOAA-EMC#3008) Update global jdas enkf diag job with COMIN/COMOUT for COM prefix (NOAA-EMC#2959) Add run and finalize methods to marine LETKF task (NOAA-EMC#2944) Fix wave restarts and GEFS FHOUT/FHMAX (NOAA-EMC#3009) Disabling hyper-threading (NOAA-EMC#2965) GitHub Actions Pipeline Updates for Self-Hosted Runners on PW (NOAA-EMC#3018) CI jekninsfile update hotfix (NOAA-EMC#3038) Update gdas.cd (NOAA-EMC#2978) Add ability to add tag to pslots with generate_workflows (NOAA-EMC#3036) CI update to shell environment with HOMEgfs to HOME_GFS for systems that need the path (NOAA-EMC#3013) Quick updated to Jenkins (health check) launch script (NOAA-EMC#3033) Document the generate_workflows.sh script (NOAA-EMC#3028) Replace gfs_cyc with an interval (NOAA-EMC#2928) Hotfix: Fix generate_workflows.sh optional build flags (NOAA-EMC#3024) Add a tool to run multiple YAML cases locally (NOAA-EMC#3004) Hotfix: Correctly set overwrite option when specified (NOAA-EMC#3021)

AntonMFernando-NOAA and others added 6 commits December 20, 2024 12:59

modified scripts\exgfs_wave_post_gridded_sbs.sh

7f00d08

Merge branch 'NOAA-EMC:develop' into feature/remove_waveGRD

1d1a0f3

modified ush\forecast_postdet.sh and ush\wave_grid_interp_sbs.sh

471b759

Merge branch 'feature/remove_waveGRD' of https://github.com/AntonMFer…

b3992d7

…nando-NOAA/global-workflow into feature/remove_waveGRD

modified ush\parsing_namelists_WW3.sh

af0e86f

modified scripts\exgfs_wave_post_gridded_sbs.sh

1b0765b

github-advanced-security bot found potential problems Dec 20, 2024

View reviewed changes

ush/parsing_namelists_WW3.sh Fixed Show fixed Hide fixed

ush/parsing_namelists_WW3.sh Fixed Show fixed Hide fixed

AntonMFernando-NOAA added 2 commits December 20, 2024 16:05

modified ush\parsing_namelists_WW3.sh

12acba6

added waveMULTIGRID='.false.'

e070372

JessicaMeixner-NOAA reviewed Dec 20, 2024

View reviewed changes

parm/config/gfs/config.wave Outdated Show resolved Hide resolved

AntonMFernando-NOAA added 2 commits December 20, 2024 18:58

remove the variable waveMULTIGRID

0e0c1b9

removed waveMULTIGRID var

5f38480

AntonMFernando-NOAA force-pushed the feature/remove_waveGRD branch from 5491f6a to 5f38480 Compare December 22, 2024 23:49

AntonMFernando-NOAA added 2 commits December 22, 2024 18:50

modified scripts\exgfs_wave_post_gridded_sbs.sh

1f9319c

modified ush\wave_grid_interp_sbs.sh

1be896c

AntonMFernando-NOAA marked this pull request as ready for review December 23, 2024 16:39

AntonMFernando-NOAA requested review from sbanihash, WalterKolczynski-NOAA, aerorahul and junwang-noaa as code owners December 23, 2024 16:39

AntonMFernando-NOAA removed the request for review from junwang-noaa December 23, 2024 16:39

aerorahul reviewed Dec 23, 2024

View reviewed changes

ush/forecast_postdet.sh Show resolved Hide resolved

ush/parsing_namelists_WW3.sh Outdated Show resolved Hide resolved

ush/parsing_namelists_WW3.sh Outdated Show resolved Hide resolved

added quotes to ush\parsing_namelists_WW3.sh

3b21bf5

github-advanced-security bot found potential problems Dec 23, 2024

View reviewed changes

ush/parsing_namelists_WW3.sh Fixed Show fixed Hide fixed

added quotes to ush\parsing_namelists_WW3.sh

a04be83

sbanihash reviewed Dec 23, 2024

View reviewed changes

Merge branch 'develop' into feature/remove_waveGRD

620df1a

sbanihash previously approved these changes Dec 24, 2024

View reviewed changes

Merge branch 'develop' into feature/remove_waveGRD

e9af5b0

WalterKolczynski-NOAA removed the CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed label Jan 7, 2025

WalterKolczynski-NOAA removed CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Jan 7, 2025

KateFriedman-NOAA added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Jan 7, 2025

aerorahul approved these changes Jan 7, 2025

View reviewed changes

JessicaMeixner-NOAA mentioned this pull request Jan 7, 2025

Make assorted updates to waves #3190

Merged

21 tasks

JessicaMeixner-NOAA approved these changes Jan 7, 2025

View reviewed changes

aerorahul requested a review from sbanihash January 7, 2025 15:45

sbanihash approved these changes Jan 7, 2025

View reviewed changes

KateFriedman-NOAA added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Jan 7, 2025

aerorahul merged commit fececaf into NOAA-EMC:develop Jan 7, 2025
10 of 11 checks passed

AntonMFernando-NOAA deleted the feature/remove_waveGRD branch January 8, 2025 01:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove multi-grid wave support #3188

Remove multi-grid wave support #3188

AntonMFernando-NOAA commented Dec 20, 2024 •

edited

Loading

aerorahul left a comment

sbanihash left a comment

AntonMFernando-NOAA commented Dec 24, 2024 •

edited

Loading

sbanihash left a comment •

edited

Loading

KateFriedman-NOAA commented Jan 7, 2025

KateFriedman-NOAA commented Jan 7, 2025

KateFriedman-NOAA commented Jan 7, 2025

aerorahul commented Jan 7, 2025

aerorahul left a comment

sbanihash left a comment

Remove multi-grid wave support #3188

Remove multi-grid wave support #3188

Conversation

AntonMFernando-NOAA commented Dec 20, 2024 • edited Loading

Description

Type of change

Change characteristics

How has this been tested?

Checklist

aerorahul left a comment

Choose a reason for hiding this comment

sbanihash left a comment

Choose a reason for hiding this comment

AntonMFernando-NOAA commented Dec 24, 2024 • edited Loading

sbanihash left a comment • edited Loading

Choose a reason for hiding this comment

KateFriedman-NOAA commented Jan 7, 2025

KateFriedman-NOAA commented Jan 7, 2025

KateFriedman-NOAA commented Jan 7, 2025

aerorahul commented Jan 7, 2025

aerorahul left a comment

Choose a reason for hiding this comment

sbanihash left a comment

Choose a reason for hiding this comment

AntonMFernando-NOAA commented Dec 20, 2024 •

edited

Loading

AntonMFernando-NOAA commented Dec 24, 2024 •

edited

Loading

sbanihash left a comment •

edited

Loading