Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up GSI analysis jobs in CI testing #3115

Conversation

CoryMartin-NOAA
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA commented Nov 20, 2024

Description

This PR adds DO_TEST_MODE, which can be used for other things in the future but for now sets the GSI to run just 5 iterations per outer loop to reduce runtime for CI testing.

Resolves #3114

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? MAYBE
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Clone and build on Hera
  • Cycled test on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward PR. Approve ... but did not test.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Nov 22, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules labels Nov 22, 2024
@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Nov 22, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Nov 22, 2024
@emcbot
Copy link

emcbot commented Nov 22, 2024

Experiment C48_S2SW FAILED on Hera in Build# 2 with error logs:

/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C48_S2SW_0bb9078e/logs/2021032312/gfs_stage_ic.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 22, 2024
@emcbot
Copy link

emcbot commented Nov 22, 2024

Experiment C48_S2SW FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/EXPDIR/C48_S2SW_0bb9078e

@JessicaMeixner-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA I was pointed to this failure offline because it was about a wave IC issue:

SError: unable to copy /scratch1/NCEPDEV/global/glopara/data/ICSDIR/C48mx500/20240610/gfs.20210323/06/model/wave/restart/20210323.120000.restart.ww3 to /scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C48_S2SW_0bb9078e/gfs.20210323/06//model/wave/restart/20210323.120000.restart.ww3

I'm concerned that changes in staging of wave ICs has messed up existing regression tests in prep for #3112
removing the grid id perhaps is causing an issue because we have many wave gridids that are used in various places and what was copied to ww3? And where? I'll continue this conversation in 3112. I don't think we want to break other tests before 3112 is merged do we? And perahps we need to carefully go through and make sure ICs are properly placed for various wave grids for various CI tests. I'm unsure about this now.

@emcbot
Copy link

emcbot commented Nov 22, 2024

Experiment C48_S2SWA_gefs FAILED on Hera in Build# 2 with error logs:

/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C48_S2SWA_gefs_0bb9078e/logs/2021032312/gefs_stage_ic.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Nov 22, 2024

Experiment C48_S2SWA_gefs FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/EXPDIR/C48_S2SWA_gefs_0bb9078e

@WalterKolczynski-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA I was pointed to this failure offline because it was about a wave IC issue:

SError: unable to copy /scratch1/NCEPDEV/global/glopara/data/ICSDIR/C48mx500/20240610/gfs.20210323/06/model/wave/restart/20210323.120000.restart.ww3 to /scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C48_S2SW_0bb9078e/gfs.20210323/06//model/wave/restart/20210323.120000.restart.ww3

I'm concerned that changes in staging of wave ICs has messed up existing regression tests in prep for #3112 removing the grid id perhaps is causing an issue because we have many wave gridids that are used in various places and what was copied to ww3? And where? I'll continue this conversation in 3112. I don't think we want to break other tests before 3112 is merged do we? And perahps we need to carefully go through and make sure ICs are properly placed for various wave grids for various CI tests. I'm unsure about this now.

A few symlinks got broken somehow. Breaking old tests was not intentional. The links are restored now.

@emcbot
Copy link

emcbot commented Nov 22, 2024

Experiment C96C48_hybatmDA FAILED on Hera in Build# 3 in
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/EXPDIR/C96C48_hybatmDA_0bb9078e

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 22, 2024
@emcbot
Copy link

emcbot commented Nov 22, 2024

CI Failed on Hera in Build# 3
Built and ran in directory /scratch1/NCEPDEV/global/CI/3115


Experiment C96_S2SWA_gefs_replay_ics_0bb9078e Completed 1 Cycles: *SUCCESS* at Fri Nov 22 19:26:19 UTC 2024
Experiment C96_atm3DVar_0bb9078e Terminated with 0
FAIL
FAIL tasks failed and 20 dead at Fri Nov 22 19:56:33 UTC 2024
Experiment C96_atm3DVar_0bb9078e Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f000.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f003.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f006.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f009.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f012.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f015.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f018.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f021.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f024.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f027.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f030.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f033.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f036.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f039.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f042.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f045.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f048.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f051.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f054.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f057.log
Experiment C48mx500_3DVarAOWCDA_0bb9078e Completed 2 Cycles: *SUCCESS* at Fri Nov 22 20:02:37 UTC 2024
Experiment C48_ATM_0bb9078e Completed 2 Cycles: *SUCCESS* at Fri Nov 22 20:02:38 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 22, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Nov 22, 2024
@emcbot
Copy link

emcbot commented Nov 22, 2024

Checkout Failed on Hera in Build# 5: null

1 similar comment
@emcbot
Copy link

emcbot commented Nov 22, 2024

Checkout Failed on Hera in Build# 5: null

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Nov 22, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 22, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Nov 22, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Nov 22, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 23, 2024
@emcbot
Copy link

emcbot commented Nov 23, 2024

CI Passed on Hera in Build# 7
Built and ran in directory /scratch1/NCEPDEV/global/CI/3115


Experiment C96_S2SWA_gefs_replay_ics_baccdedd Completed 1 Cycles: *SUCCESS* at Sat Nov 23 13:15:45 UTC 2024
Experiment C48mx500_3DVarAOWCDA_baccdedd Completed 2 Cycles: *SUCCESS* at Sat Nov 23 13:27:55 UTC 2024
Experiment C48_ATM_baccdedd Completed 2 Cycles: *SUCCESS* at Sat Nov 23 13:33:59 UTC 2024
Experiment C96C48_hybatmaerosnowDA_baccdedd Completed 3 Cycles: *SUCCESS* at Sat Nov 23 14:47:18 UTC 2024
Experiment C96C48_hybatmDA_baccdedd Completed 3 Cycles: *SUCCESS* at Sat Nov 23 14:47:19 UTC 2024
Experiment C48_S2SWA_gefs_baccdedd Completed 1 Cycles: *SUCCESS* at Sat Nov 23 14:48:19 UTC 2024
Experiment C96_atm3DVar_baccdedd Completed 3 Cycles: *SUCCESS* at Sat Nov 23 14:53:11 UTC 2024
Experiment C48_S2SW_baccdedd Completed 2 Cycles: *SUCCESS* at Sat Nov 23 15:23:38 UTC 2024
Experiment C96C48_ufs_hybatmDA_baccdedd Completed 3 Cycles: *SUCCESS* at Sat Nov 23 15:30:11 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit efc25be into NOAA-EMC:develop Nov 23, 2024
10 of 11 checks passed
WalterKolczynski-NOAA pushed a commit that referenced this pull request Dec 12, 2024
…est (#3120)

This PR is a companion to NOAA-EMC/GDASApp#1365

It turns ```C96C48_ufs_hybatmDA``` and ```C48mx500_3DVarAOWCDA``` into a
regression test using the JEDI application testing feature. This feature
is turned on using the new ```DO_TEST_MODE``` parameter added to
```config.base``` in GW PR
[#3115](#3115). This
parameter is set to ```"YES"``` in the yaml defaults for the JEDI-based
CI tests in GW.

The motivation for this PR is a need to catch changes in JEDI which
alter the outputs of our applications.
---------

Co-authored-by: CoryMartin-NOAA <[email protected]>
Co-authored-by: RussTreadon-NOAA <[email protected]>
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Jan 27, 2025
* develop:
  Remove WAFS files and references from `develop` (NOAA-EMC#3263)
  fix intel stack version number on c5 (NOAA-EMC#3258)
  Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252)
  Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255)
  Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235)
  Only run METplus in the 3Dvar tests (NOAA-EMC#3245)
  Clone, build, and run C48_ATM and C48_S2SW on Gaea C5 and C6 (NOAA-EMC#3106)
  Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246)
  Add domain level to wave gridded COM path (NOAA-EMC#3137)
  CI JJOB Tests using CMake (NOAA-EMC#3214)
  Make assorted updates to waves (NOAA-EMC#3190)
  Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236)
  Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211)
  Add additional GEFS variables needed for AI/ML applications  (NOAA-EMC#3221)
  Add bmat task dependency to marine LETKF task (NOAA-EMC#3224)
  Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229)
  Reinstate product groups (NOAA-EMC#3208)
  Additional fixes for downstream jobs (NOAA-EMC#3187)
  Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215)
  Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220)
  Update upload-artifact to v4 (NOAA-EMC#3216)
  Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217)
  Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
  Separate use of initial increment/perturbation file from REPLAY/+03 ICs  (NOAA-EMC#3119)
  Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207)
  Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212)
  Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146)
  Remove multi-grid wave support (NOAA-EMC#3188)
  Add echgres as a dependency for earc (NOAA-EMC#3202)
  Ensure OCNRES and ICERES have 3 digits in the archive script (NOAA-EMC#3199)
  Set runtime shell requirements within Jenkins Pipeline (NOAA-EMC#3171)
  Add efcs and epos to ufs_hybatm xml (NOAA-EMC#3192) (NOAA-EMC#3193)
  Fix GEFS and SFS compile flags in build_all.sh (NOAA-EMC#3197)
  Remove early-cycle EnKF forecast (NOAA-EMC#3185)
  Fix mod_icec bug in atmos_prod (NOAA-EMC#3167)
  Create compute build option (NOAA-EMC#3186)
  Support global-workflow using Rocky 8 on CSPs (NOAA-EMC#2998)
  Change orog gravity wave drag scheme for grid sizes less than 10km (NOAA-EMC#3175)
  Switch snow DA to use 2DVar for deterministic and ensemble mean (NOAA-EMC#3163)
  Update compression options for GEFS history files (NOAA-EMC#3184)
  Update compression options for high res history files (NOAA-EMC#3178)
  Turn DO_TEST_MODE off (NOAA-EMC#3177)
  Hotfix for gdas_arch div/0 (NOAA-EMC#3169)
  Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow (NOAA-EMC#3098)
  Switch Aerosol DA to use JCB and Jedi class (NOAA-EMC#3125)
  Update ufs-weather-model to 2024-12-06 commit  (NOAA-EMC#3145)
  Enable traditional threading as an option (NOAA-EMC#3149)
  Update HPC_ACCOUNT on Hercules to fv3-cpu (NOAA-EMC#3164)
  Turn C96C48_ufs_hybatmDA and C48mx500_3DVarAOWCDA into a regression test (NOAA-EMC#3120)
  Update GSI analysis jobs to use COMIN/COMOUT (NOAA-EMC#3092)
  Update HPC Tier Definitions (NOAA-EMC#3138)
  Add marine hybrid envar (NOAA-EMC#3041)
  Archive the experiment directory along with git status/diff output (NOAA-EMC#3105)
  Use stochastic restart patterns on rerun (NOAA-EMC#3077)
  Point Jenkinsfile back to CI/ (NOAA-EMC#3139)
  Fix wave restart for cold start and add ic version file (NOAA-EMC#3112)
  Allow users to override the default account at setup time (NOAA-EMC#3127)
  Refactor gridded wave post (NOAA-EMC#3014)
  Update docs related to NOAA CSPs (NOAA-EMC#3043)
  Allow APP to differ between RUNs (NOAA-EMC#2943)
  Run one executable for soca2cice (instead of two) (NOAA-EMC#3118)
  Speed up GSI analysis jobs in CI testing (NOAA-EMC#3115)
  Make aerosol output frequency variable (NOAA-EMC#2982)
  Add new stations to GFS BUFR sounding products (NOAA-EMC#3107)
  JCB-based obs+bias staging, Jedi class updates, and marine B-matrix refactoring (NOAA-EMC#2992)
  Enable tapering of atm ens perts at the model top (NOAA-EMC#3097)
  Update JGDAS ENKF POST  job  (NOAA-EMC#3090)
  SFS Runs at C96mx100  (NOAA-EMC#2960)
  Move machine-based options from config.base to host files (NOAA-EMC#3053)
  Remove RUNDIRS before running CI cases to cover re-run events (NOAA-EMC#3076)
  CI GitHub pipeline (hotfix) update for fetching repo name (NOAA-EMC#3084)
  Update JGDAS ENKF ECEN job  (NOAA-EMC#3050)
  Update snow obs processing job (NOAA-EMC#3055)
  Update to action workflow pipeline in default repo for development  (NOAA-EMC#3062)
  Update to action workflow pipeline in default repo for development (NOAA-EMC#3061)
  Update workflow pipeline (NOAA-EMC#3060)
  PW CI pipeline update5 ready for review so it can be merged and tested (NOAA-EMC#3059)
  Revert "GitHub CI Pipeline update for debugging forked PR support" (NOAA-EMC#3057)
  GitHub CI Pipeline update for debugging forked PR support (NOAA-EMC#3056)
  Add more ocean variables for post-processing in GEFS (NOAA-EMC#2995)
  Auto provisioning of PW clusters from GitHub CI added (NOAA-EMC#3051)
  Fix the name of the TC tracker filenames in archive.py (NOAA-EMC#3030)
  Make wxflow links static instead of from link_workflow (NOAA-EMC#3008)
  Update global jdas enkf diag job with COMIN/COMOUT for COM prefix (NOAA-EMC#2959)
  Add run and finalize methods to marine LETKF task (NOAA-EMC#2944)
  Fix wave restarts and GEFS FHOUT/FHMAX (NOAA-EMC#3009)
  Disabling hyper-threading (NOAA-EMC#2965)
  GitHub Actions Pipeline Updates for Self-Hosted Runners on PW (NOAA-EMC#3018)
  CI jekninsfile update hotfix (NOAA-EMC#3038)
  Update gdas.cd (NOAA-EMC#2978)
  Add ability to add tag to pslots with generate_workflows (NOAA-EMC#3036)
  CI update to shell environment with HOMEgfs to HOME_GFS for systems that need the path (NOAA-EMC#3013)
  Quick updated to Jenkins (health check) launch script (NOAA-EMC#3033)
  Document the generate_workflows.sh script (NOAA-EMC#3028)
  Replace gfs_cyc with an interval (NOAA-EMC#2928)
  Hotfix: Fix generate_workflows.sh optional build flags (NOAA-EMC#3024)
  Add a tool to run multiple YAML cases locally (NOAA-EMC#3004)
  Hotfix: Correctly set overwrite option when specified (NOAA-EMC#3021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up GSI run in CI tests
7 participants