Remove remaining jlogfile references

[KateFriedman-NOAA]

What new functionality do you need?

The jlogfile was retired by NCO in the move to WCOSS2. It's use was removed from most places but some instances still linger and should be removed. Related references to postmsg should also be removed.

A scan for "jlogfile" in a checked out clone of global-workflow gives the lists below. A workflow developer will take care of cleaning out the references in global-workflow scripts.

Workflow:

gempak/ush/gempak_gfs_f24_gif.sh:   postmsg "$jlogfile" "$msg"
gempak/ush/gempak_gfs_f24_gif.sh:   postmsg "$jlogfile" "$msg"
gempak/ush/gempak_gdas_f000_gif.sh:   postmsg "$jlogfile" "$msg"
gempak/ush/gempak_gdas_f000_gif.sh:   postmsg "$jlogfile" "$msg"
gempak/ush/gempak_gfs_f48_gif.sh:   postmsg "$jlogfile" "$msg"
gempak/ush/gempak_gfs_f48_gif.sh:   postmsg "$jlogfile" "$msg"
gempak/ush/gempak_gfs_f12_gif.sh:   postmsg "$jlogfile" "$msg"
gempak/ush/gempak_gfs_f12_gif.sh:   postmsg "$jlogfile" "$msg"
gempak/ush/gempak_gfs_f00_gif.sh:   postmsg "$jlogfile" "$msg"
gempak/ush/gempak_gfs_f00_gif.sh:   postmsg "$jlogfile" "$msg"
gempak/ush/gempak_gfs_f36_gif.sh:   postmsg "$jlogfile" "$msg"
gempak/ush/gempak_gfs_f36_gif.sh:   postmsg "$jlogfile" "$msg"
ush/minmon_xtrct_gnorms.pl:   print "usage: minmon_xtrct_gnorms.pl SUFFIX pdy cyc infile jlogfile\n";
ush/minmon_xtrct_gnorms.pl:my $jlogfile = $ARGV[4];
ush/radmon_verf_time.sh:#pgmout=${pgmout:-${jlogfile}}
ush/radmon_verf_bcoef.sh:pgmout=${pgmout:-${jlogfile}}
ush/minmon_xtrct_reduct.pl:     print "usage: minmon_xtrct_reduct.pl SUFFIX pdy cyc infile jlogfile\n";
ush/minmon_xtrct_reduct.pl:        print " jlogfile is the job log file\n";
ush/minmon_xtrct_reduct.pl:my $jlogfile = $ARGV[4];
ush/minmon_xtrct_costs.pl:      print "usage: minmon_xtrct_costs.pl SUFFIX PDY cyc infile jlogfile\n";
ush/minmon_xtrct_costs.pl:my $jlogfile = $ARGV[4];
ush/radmon_verf_bcor.sh:pgmout=${pgmout:-${jlogfile}}
ush/radmon_verf_angle.sh:export pgmout=${pgmout:-${jlogfile}}
ush/syndat_getjtbul.sh:#   jlogfile  - path to job log file (skipped over by this script if not

GSI-Monitor (@EdwardSafford-NOAA):

sorc/gsi_monitor.fd/src/Radiance_Monitor/nwprod/nam_radmon/jobs/JNAM_VERFRAD:export jlogfile=${jlogfile:-${COMROOT}/logs/jlogfiles/jlogfile.${job}.${pid}}
sorc/gsi_monitor.fd/src/Radiance_Monitor/nwprod/gdas_radmon/driver/test_jgdas_verfrad_hera.sh:export jlogfile=jlogfile.${PDATE}
sorc/gsi_monitor.fd/src/Radiance_Monitor/nwprod/gdas_radmon/driver/test_jgdas_verfrad_orion.sh:export jlogfile=jlogfile.${PDATE}
sorc/gsi_monitor.fd/src/Radiance_Monitor/nwprod/gdas_radmon/driver/test_jgdas_verfrad_wcoss2.sh:if [[ ! -d ${COMROOT}/logs/jlogfiles ]]; then
sorc/gsi_monitor.fd/src/Radiance_Monitor/nwprod/gdas_radmon/driver/test_jgdas_verfrad_wcoss2.sh:   mkdir -p ${COMROOT}/logs/jlogfiles
sorc/gsi_monitor.fd/src/Radiance_Monitor/nwprod/gdas_radmon/driver/test_jgdas_verfrad_wcoss2.sh:export jlogfile=${COMROOT}/logs/jlogfiles/${RADMON_SUFFIX}_jlog
sorc/gsi_monitor.fd/src/Radiance_Monitor/data_extract/ush/RadMon_DE_glb.sh:   export jlogfile=${R_LOGDIR}/jlogfile_${RADMON_SUFFIX}
sorc/gsi_monitor.fd/src/Radiance_Monitor/data_extract/ush/RadMon_DE_rgn.sh:export jlogfile=${R_LOGDIR}/jlogfile.${PDY}.${cyc}
sorc/gsi_monitor.fd/src/Minimization_Monitor/nwprod/nam_minmon/jobs/JNAM_MINMON:export jlogfile=${jlogfile:-${COMROOT}/logs/jlogfiles/jlogfile.${m_job}.${pid}}
sorc/gsi_monitor.fd/src/Minimization_Monitor/nwprod/nam_minmon/jobs/JNAM_MINMON:postmsg "$jlogfile" "$msg"
sorc/gsi_monitor.fd/src/Minimization_Monitor/nwprod/nam_minmon/jobs/JNAM_MINMON:postmsg "$jlogfile" "$msg"
sorc/gsi_monitor.fd/src/Minimization_Monitor/nwprod/nam_minmon/scripts/exnam_vrfminmon.sh.ecf:postmsg "$jlogfile" "$msg"
sorc/gsi_monitor.fd/src/Minimization_Monitor/nwprod/nam_minmon/scripts/exnam_vrfminmon.sh.ecf:   ${USHminmon}/minmon_xtrct_costs.pl ${MINMON_SUFFIX} ${PDY} ${cyc} ${gsista
t} ${jlogfile}
sorc/gsi_monitor.fd/src/Minimization_Monitor/nwprod/nam_minmon/scripts/exnam_vrfminmon.sh.ecf:   ${USHminmon}/minmon_xtrct_gnorms.pl ${MINMON_SUFFIX} ${PDY} ${cyc} ${gsist
at} ${jlogfile}
sorc/gsi_monitor.fd/src/Minimization_Monitor/nwprod/nam_minmon/scripts/exnam_vrfminmon.sh.ecf:   ${USHminmon}/minmon_xtrct_reduct.pl ${MINMON_SUFFIX} ${PDY} ${cyc} ${gsist
at} ${jlogfile}
sorc/gsi_monitor.fd/src/Minimization_Monitor/nwprod/nam_minmon/scripts/exnam_vrfminmon.sh.ecf:postmsg "$jlogfile" "$msg"
sorc/gsi_monitor.fd/src/Ozone_Monitor/nwprod/gdas_oznmon/driver/test_jgdas_verfozn_wcoss2.sh:if [[ ! -d ${COMROOT}/logs/jlogfiles ]]; then
sorc/gsi_monitor.fd/src/Ozone_Monitor/nwprod/gdas_oznmon/driver/test_jgdas_verfozn_wcoss2.sh:   mkdir -p ${COMROOT}/logs/jlogfiles

GSI-Utils (@CoryMartin-NOAA @RussTreadon-NOAA):

sorc/gsi_utils.fd/src/global_angupdate/JGDAS_ANGUPDATE:  export jlogfile=${jlogfile:-/com/logs/${envir}/jlogfile}
sorc/gsi_utils.fd/src/global_angupdate/JGDAS_ANGUPDATE:   export jlogfile=${jlogfile:-/com/logs/jlogfiles/jlogfile.${job}.${pid}}
sorc/gsi_utils.fd/src/global_angupdate/JGDAS_ANGUPDATE:   export jlogfile=${jlogfile:-/com/logs/${envir}/jlogfile}
sorc/gsi_utils.fd/src/global_angupdate/JGDAS_ANGUPDATE:./postmsg "$jlogfile" "$msg"
sorc/gsi_utils.fd/src/global_angupdate/JGDAS_ANGUPDATE:   ./postmsg "$jlogfile" "$msg"
sorc/gsi_utils.fd/src/global_angupdate/JGDAS_ANGUPDATE:   ./postmsg "$jlogfile" "$msg"
sorc/gsi_utils.fd/src/global_angupdate/JGDAS_ANGUPDATE:./postmsg "$jlogfile" "$msg"

What are the requirements for the new functionality?

No more jlogfile.

Acceptance Criteria

All remaining instances of jlogfile are gone.

Suggest a solution (optional)

No response

[aerorahul]

@KateFriedman-NOAA
JGDAS_ANGUPDATE is no longer used in current ops. This can be ignored or the job deleted.
The NAM files in the monitoring suite are benign as they are not used in the global apps. I think we can ignore them. I am not sure if the NAM package is using these currently, in which case they could be sanitized in GSI-monitor if so desired.

[HenryRWinterbottom]

@KateFriedman-NOAA I have gotten all of the jlogfile and postmsg references for the GW scripts listed above, with the exception of the following:

• ush/radmon_verf_bcoef.sh
• ush/radmon_verf_bcor.sh
• ush/radmon_verf_angle.sh

The pgmout variable in the above scripts depends on either pgmout being passed to the script or it defaults to jlogfile. Since we are getting rid of the jlogfile references, how do you suggest that we proceed with this?

My branch within my fork is https://github.com/HenryWinterbottom-NOAA/global-workflow/tree/feature/gfsv17_issue_2125

[KateFriedman-NOAA]

@HenryWinterbottom-NOAA Pretty sure you can just remove lines like this entirely: https://github.com/HenryWinterbottom-NOAA/global-workflow/blob/feature/gfsv17_issue_2125/ush/radmon_verf_bcoef.sh#L72

...but, first check that pgmout definitely comes into that script with a value. The GSI monitoring jobs are turned on by default so if you have any logs from recent runs you can check the pgmout setting in those job logs. Or, something I generally suggest for most g-w tasks, run a short low-res 1.5 atmos-only cycled test once all your changes are made, to make sure all is well. Then CI tests can cover the other platforms.

[HenryRWinterbottom]

@KateFriedman-NOAA Thanks for the feedback. Still slogging through the RDHPCS Hera queue. My first experiment yielded the following Rocoto dump:

202112210000                gdasprep                    55455199           SUCCEEDED                   0         1         217.0
202112210000                gdasanal                    55455345           SUCCEEDED                   0         1        1237.0
202112210000              gdassfcanl                    55456336           SUCCEEDED                   0         1          32.0
202112210000            gdasanalcalc                    55456634           SUCCEEDED                   0         1          24.0
202112210000            gdasanaldiag                    55456337           SUCCEEDED                   0         1          75.0
202112210000           gdasatmanlupp                    55456763           SUCCEEDED                   0         1          19.0
202112210000          gdasatmanlprod                    55457040           SUCCEEDED                   0         1          42.0
202112210000                gdasfcst                    55456635           SUCCEEDED                   0         1         533.0
202112210000    gdasatmprod_f000-f003                    55454891           SUCCEEDED                   0         1          84.0
202112210000    gdasatmprod_f006-f009                    55454892           SUCCEEDED                   0         1          85.0
202112210000             gdasfit2obs                    55455232                DEAD                   1         2           8.0
202112210000             gdasverfozn                    55456636           SUCCEEDED                   0         1          16.0
202112210000             gdasverfrad                    55456637           SUCCEEDED                   0         1         457.0
202112210000             gdasvminmon                    55456338           SUCCEEDED                   0         1           9.0
202112210000                gdasarch                           -                   -                   -         -             -
202112210000             gdascleanup                           -                   -                   -         -             -
202112210000                 gfsprep                    55455201           SUCCEEDED                   0         1         200.0
202112210000                 gfsanal                    55455346           SUCCEEDED                   0         1         824.0
202112210000               gfssfcanl                    55456180           SUCCEEDED                   0         1          31.0
202112210000             gfsanalcalc                    55456339           SUCCEEDED                   0         1          26.0
202112210000            gfsatmanlupp                    55456638           SUCCEEDED                   0         1          20.0
202112210000           gfsatmanlprod                    55456764           SUCCEEDED                   0         1          64.0
202112210000                 gfsfcst                    55456639           SUCCEEDED                   0         2         533.0
202112210000    gfsatmprod_f000-f012                    55454894           SUCCEEDED                   0         1         192.0
202112210000              gfsvminmon                    55456181           SUCCEEDED                   0         1           9.0
202112210000                 gfsarch                    55457459                DEAD                   1         2           9.0
202112210000              gfscleanup                           -                   -                   -         -             -

I expected the gfsarch failure (since I turned it off). Is it common for gdasfit2obs to fail. I thought I recalled something regarding this application but cannot remember beyond that.

[KateFriedman-NOAA]

@HenryWinterbottom-NOAA Can you point me to your test logs so I can take a look at why fit2obs failed?

[HenryRWinterbottom]

@KateFriedman-NOAA I found the problem, user error. Thanks for following-up.