-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[production/RRFS.v1] Fix 'check all' using 0-sized arrays #789
Merged
MatthewPyle-NOAA
merged 9 commits into
NOAA-EMC:production/RRFS.v1
from
grantfirl:feature/fix_check_all_zero_alloc_RRFS
Mar 5, 2024
Merged
[production/RRFS.v1] Fix 'check all' using 0-sized arrays #789
MatthewPyle-NOAA
merged 9 commits into
NOAA-EMC:production/RRFS.v1
from
grantfirl:feature/fix_check_all_zero_alloc_RRFS
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces #767 and is directed at the RRFS release branch. |
Merged
13 tasks
@jkbk2004 @MatthewPyle-NOAA This branch has been updated with the submodule pointers and should be ready to merge. |
MatthewPyle-NOAA
approved these changes
Mar 5, 2024
Thanks @grantfirl - will get it merged. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR at least partially addresses ufs-community/ufs-weather-model#2023 (at least any runtime errors associated with the CCPP). The strategy is to simply make sure that every variable is allocated, although for variables that had been conditionally-allocated to save memory, they are now being allocated with zero size. This has a ripple effect in other repos where one needs to change from checking whether a variable is allocated to whether the size is > 0.
Note: There was also some cleanup done to remove variables that are declared in GFS_ and CCPP_typedefs.F90 but are not being used anywhere anymore. In addition, the ACTIVE attribute in the metadata files was double-checked for every conditionally-allocated variable.
Issue(s) addressed
ufs-community/ufs-weather-model#2023
Testing
This was tested with the full RT suite on Hera with the
-check all
compilation flag added in the ufs-weather-model Intel.cmake file. All tests completed successfully with no BL changes.Dependencies