Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for the NoahMP tiled t2m and q2m #607

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

ChunxiZhang-NOAA
Copy link
Contributor

@ChunxiZhang-NOAA ChunxiZhang-NOAA commented Dec 1, 2022

Description

This PR is created on behalf of Helin Wei and the Land team@EMC

This PR fixed a bug for the NoahMP internal diagnosed tiled values for t2m and q2m. Those values over the bared soil have been improved significantly after the bug fix.

Issue(s) addressed

The issue is described in ccpp-physics PR#25.

Testing

The description of testing is provided in the corresponding ufs-weather-model PR.

Dependencies

  • waiting on ufs-community/ccpp-physics/pull/<25>

@ChunxiZhang-NOAA ChunxiZhang-NOAA changed the title Using NoahMP tiled t2m and q2m after the bug fix Use NoahMP tiled t2m and q2m after the bug fix Dec 1, 2022
@ChunxiZhang-NOAA ChunxiZhang-NOAA changed the title Use NoahMP tiled t2m and q2m after the bug fix Bug fix for the NoahMP tiled t2m and q2m Dec 1, 2022
@ChunxiZhang-NOAA
Copy link
Contributor Author

@jkbk2004 @BrianCurtis-NOAA ccpp/physics branch is reverted and hash is updated.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Dec 2, 2022

I think @DusanJovic-NOAA may take off today. @BrianCurtis-NOAA we can merge in with your approval.

@jkbk2004 jkbk2004 merged commit b36a391 into NOAA-EMC:develop Dec 2, 2022
@grantfirl grantfirl mentioned this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants