Add 2d domain decomposition to the inline post #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2022 14:57
6ee5395 plus upp post_2d_decomp
16 tasks
junwang-noaa
reviewed
Jun 6, 2022
junwang-noaa
reviewed
Jun 6, 2022
junwang-noaa
reviewed
Jun 6, 2022
junwang-noaa
reviewed
Jun 6, 2022
junwang-noaa
reviewed
Jun 6, 2022
DusanJovic-NOAA
changed the title
|
@DusanJovic-NOAA @junwang-noaa @JesseMeng-NOAA I think we can merge in this PR. Can you check again and leave any comment if needed? |
junwang-noaa
approved these changes
Jun 13, 2022
DusanJovic-NOAA
approved these changes
Jun 13, 2022
WenMeng-NOAA
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resubmit an update from previous PR, after many updates in upp and other fv3atm submodules.
The community upp is currently decomposed on latitudes (y-direction) only. As the ufs-weather-model is making 2D decomposition in both latitudes and longitudes (Y and X), one of the upp refactoring tasks is to support ufs-weather-model inline post 2D decomposition functionality.
A ufs-weather-model PR was created for this test with inline post turned on in the control_2dwrtdecomp and regional_control_2dwrtdecomp tests,
ufs-community/ufs-weather-model#1211
The upp/post_2d_decomp branch can be found at
https://github.com/WenMeng-NOAA/UPP/tree/post_2d_decomp
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Several io/ subroutines are modified to call upp/post_2d_decomp functions
Is a change of answers expected from this PR?
This PR does not change the output.
Issue(s) addressed
ufs-community/ufs-weather-model#1078
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
Build the BASE with ufs-weather-model/develop
run control fv3 and regional_control fv3
Checkout the branch for this PR
https://github.com/JesseMeng-NOAA/fv3atm/tree/feature/upp_unify_inline_2d
run control_2dwrtdecomp and regional_control_2dwrtdecomp
Compare the results to confirm identical outputs are reproduced.
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
https://github.com/WenMeng-NOAA/UPP/tree/post_2d_decomp