-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added coupling of GOCART aerosols with radiation related to issue#899… #525
Conversation
… in NCAR/ccpp-physics
looks good. Approved |
Bc means black carbon
…On Thu, May 5, 2022 at 10:34 AM Grant Firl ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ccpp/data/GFS_typedefs.meta
<#525 (comment)>:
> + dimensions = ()
+ type = integer
+[ntss5]
+ standard_name = index_for_seasalt_bin5
+ long_name = index for seasalt bin5
+ units = index
+ dimensions = ()
+ type = integer
+[ntsu]
+ standard_name = index_for_sulfate
+ long_name = index for sulfate
+ units = index
+ dimensions = ()
+ type = integer
+[ntbcb]
+ standard_name = index_for_bcphobic
I understand phobic and philic, but what does 'bc' stand for in these
standard names? Can it be changed to something more descriptive for
non-subject matter experts?
—
Reply to this email directly, view it on GitHub
<#525 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIJWU6Z6WYYHSB5ZKJDVIPL7NANCNFSM5UL3QXLQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
On Thu, May 5, 2022 at 10:57 AM Grant Firl ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ccpp/data/GFS_typedefs.meta
<#525 (comment)>:
> + dimensions = ()
+ type = integer
+[ntss5]
+ standard_name = index_for_seasalt_bin5
+ long_name = index for seasalt bin5
+ units = index
+ dimensions = ()
+ type = integer
+[ntsu]
+ standard_name = index_for_sulfate
+ long_name = index for sulfate
+ units = index
+ dimensions = ()
+ type = integer
+[ntbcb]
+ standard_name = index_for_bcphobic
OK, thanks, @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> ,
'bc' is black carbon. I'm assuming 'oc' is organic carbon? Also, are the
philic/phobic adjectives refering to hydrophobic/hydrophilic or some other
substance? @ChunxiZhang-NOAA <https://github.com/ChunxiZhang-NOAA> Would
you mind changing associated standard names since this branch is on your
fork?
—
Reply to this email directly, view it on GitHub
<#525 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIIHD5D77BQZTGL3CFTVIPOW3ANCNFSM5UL3QXLQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
Yes. OC is organic Carbon. The are hydrophobic and hydrophilic too.
|
…ion in the Thompson scheme
…tputs in the Thompson microphysics scheme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gitmodule needs to be updated after the ccpp/physics is committed.
@ChunxiZhang-NOAA can you resolve the above conversation about "bc"? |
@jkbk2004 done. |
@ChunxiZhang-NOAA revert gitmodule pointer and then we can merge this pr. |
@ChunxiZhang-NOAA update ccpp submodule pointer as well. |
@jkbk2004 ccpp/physics submodule pointer was updated. |
Description
The coupling between GOCART aerosols and radiation was implemented. This is a new feature.
Issue(s) addressed
Issue is described here
Dependencies