Enable receiving atmosphere-ocean fluxes from external component #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fluxes from mediator
16 tasks
climbfuji
requested changes
Apr 16, 2022
climbfuji
requested review from
junwang-noaa,
DeniseWorthen and
DusanJovic-NOAA
junwang-noaa
reviewed
May 2, 2022
|
@junwang-noaa this is also ready for review |
|
submodules are updated after merging CCPP physics and framework PRs. |
DusanJovic-NOAA
approved these changes
Jun 9, 2022
|
@climbfuji Please review this PR again, and remove 'requested change'. |
|
@climbfuji Can you approve the requested changes made? @BrianCurtis-NOAA I think we can merge in after the requested changes resolved. Can you work on merging the PR? |
climbfuji
approved these changes
Jun 9, 2022
junwang-noaa
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to enable receiving atmosphere-ocean fluxes from external component such as CMEPS mediator. This is required to enable usage of exchange grid capability provided by CMEPS mediator to calculate atmosphere-ocean fluxes. It defines required data structures to send flux components to CCPP/physics and also introduces new
input.nmloption called asuse_med_fluxto thegfs_physics_nmlgroup. The default value of the new option is.false.and the FV3/CCPP Physics will not accept any flux from external sources. This allows to preserve the existing functionality in the FV3 side. With this change there is no any expected answer changes.Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
The modifications are tested under UFS weather model by running full RT suite
What compilers / HPCs was it tested with?
NCAR's Cheyenne with Intel+MPT combination
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes. New RT (
cpld_control_c96_p8_xgrid) is added in UFS level.Have the ufs-weather-model regression test been run? On what platform?
NCAR's Cheyenne with Intel+MPT combination
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
No
Please commit the regression test log files in your ufs-weather-model branch
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs