Make surface emissivity over water a persistent variable #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
force-pushed
the
make_semis_water_persistent
branch
from
3e9e0cf to
15ce9fd
Compare
climbfuji
requested review from
junwang-noaa,
DeniseWorthen,
DusanJovic-NOAA and
SMoorthi-emc
|
Adding @SMoorthi-emc only for his information later on, because he is on leave for the rest of the year. |
…e_semis_water_persistent
update lat/lon info for inline post on global latlon grid
|
@DusanJovic-NOAA please check if cb72fda AND 91d48d7 do what you suggested. Thanks! |
Looks good to me. |
16 tasks
DusanJovic-NOAA
approved these changes
Dec 6, 2021
junwang-noaa
approved these changes
Dec 6, 2021
|
Hash for ccpp-physics is correct, please merge. |
DeniseWorthen
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The surface emissivity over water is currently stored in the
GFS_interstitial_typeDDT, which is not persistent. To fix the issues described in ufs-community/ufs-weather-model#914, it needs to be moved to a persistent data type. This PR moves it to theGFS_sfcprop_type, which is already home to the surface emissivity over land and ice.Note that in the long run, in case restart reproducibility is broken,
Sfcprop%emis_watmight need to be added to the restart files. Right now it doesn't matter, because the emissivity over water is just a constant value that gets set again and again each time step.Issue(s) addressed
Fixes ufs-community/ufs-weather-model#914
Testing
See ufs-community/ufs-weather-model#921
Dependencies