Add reading of binary restart with PIO for runtype=initial #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessicaMeixner-NOAA
referenced
this pull request
in JessicaMeixner-NOAA/WW3
Jan 27, 2025
This was referenced Jan 30, 2025
15 tasks
|
@MatthewMasarik-NOAA can you review/approve this pr? |
|
@jkbk2004 - @sbanihash is in the process of reviewing this PR. I believe her hope is to have it reviewed by today. |
|
@jkbk2004 - This is ready to be merged, correct? |
Correct! All tests are done at ufs-community/ufs-weather-model#2587. Please. go ahead to merge this pr. |
JessicaMeixner-NOAA
merged commit 8e67627
into
NOAA-EMC:dev/ufs-weather-model
2 of 4 checks passed
WalterKolczynski-NOAA
pushed a commit
to NOAA-EMC/global-workflow
that referenced
this pull request
Feb 20, 2025
# Description This PR updates the wave fix which was unintentionally left out of PR #3190 Additionally, this updates what ICs the highres ci tests are pointing to (IC update issues: #3287 #3288) Resolves #3260 Refs #3326 - small changes in comments Additionally, some smaller bug fixes and changes were made: * Removes logic that tries to copy files to fix directory in ush/wave_grid_interp_sbs.sh -- Fixes #3162 * Adds MPI variables that were found needed when investigating the HR4 hang ufs-community/ufs-weather-model#2486 -- Fixes #3259 * Changes the log file output directory corresponding to an update requested by NCO in v16.3.22 in scripts/exgfs_wave_post_pnt.sh * Through debugging HR5 (#3260) it was noticed the wave ICs were not used. While there is a code change required (NOAA-EMC/WW3#1359), this PR fixes the scripting level issues & updates UFS to fix WW3 code issues. * Removes COMOUT_WAVE_PREP from wave post job that did not need it, plus ensured temporary files were not copied back to COM and then over-written (NCO bug) --- Fixes #297 * Updates ufs-weather-model hash. Details in table below Notes on ufs-weather-model updates: | Commit date | Commit hash/ PR | Notes for g-w changes | Baseline Changes | | :------------- | :------------- | :------------- | :------------- | | Jan 7, 2025 | ufs-community/ufs-weather-model@5324d64 ufs-community/ufs-weather-model#2531 | n/a | changes in regional tests, no global changes | | Jan 13, 2025 | ufs-community/ufs-weather-model@c7412fa | n/a | changes in some global coupled tests | | Jan 17, 2025 | ufs-community/ufs-weather-model@3a5e52e | n/a | no changes | | Jan 21, 2025 | ufs-community/ufs-weather-model@33cde4b | extra variable needed for waves | no changes | | Jan 22, 2025 | ufs-community/ufs-weather-model@b9d2bec | n/a | no changes | Jan 28, 2025 | ufs-community/ufs-weather-model@0682f90 | n/a | | Feb 3, 2025 | ufs-community/ufs-weather-model@a498735 | add fv3atm_output_dir to model_configure | answers change | | Feb 5, 2025 | ufs-community/ufs-weather-model@ee3d52d | changes in this PR for initialization for wave fixes | if using WW3 binary restart, answers will change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Adding capability to read WW3 restart files when using PIO and runtype=initial.
Description
For the high resolution (HR) prototypes, we want to be able to read a WW3 binary restart even though the runtype=initial. These code changes allow for that. This does not address wanting to use a NetCDF restart with runtype=initial.
Is a change of answers expected from this PR? No. Unless you are running the coupled model with runtype=initial, this will allow for ICs to now be read.
Please also include the following information:
Issue(s) addressed
Commit Message
Add reading of binary restart with PIO for runtype=initial
Check list
Testing
How were these changes tested?
--- UFS weather model PR: Update for WW3 initialization ufs-community/ufs-weather-model#2585
RegressionTests_hera.log
--- Global-workflow test output: /scratch1/NCEPDEV/climate/Jessica.Meixner/UpdateFixandHiresIC/c48t05
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) No. This is a ufs-weather-model issue and its also not covered by regresstion tests in ufs-waether-model. We do use this in production runs during the transition from binary-> netcdf restarts.
Have the matrix regression tests been run (if yes, please note HPC and compiler)? No. Will do if requested.
Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.) None.
Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
--- Will run if requested, currently have not been done.