Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Introduce under-relaxation for triads and wave breaking and integrate those terms without the limiter. #901

Closed
aronroland opened this issue Feb 20, 2023 · 1 comment
Closed

Enhancement: Introduce under-relaxation for triads and wave breaking and integrate those terms without the limiter. #901

aronroland opened this issue Feb 20, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@aronroland
Copy link
Collaborator

aronroland commented Feb 20, 2023 •
edited
Loading

Describe the bug
Enhancement: When using big time step withing non-stationary simulations, wave breaking and triads tend to introduce oscillation in the solution. We introduce now under-relaxation following the work that is done in Open-Foam. The under-relaxation coefficients are yet fixed. Moreover, due to the under-relaxation, we can integrate those terms limiter free, which is reducing time step dependency.

To Reproduce
Compare results to Boers case.

Expected behavior
Good results for the Boers case.

Screenshots
no

Additional context
no
@aronroland aronroland added the bug Something isn't working label Feb 20, 2023
@aliabdolali aliabdolali added the enhancement New feature or request label Feb 20, 2023
@aronroland aronroland mentioned this issue Feb 20, 2023
Merged
4 tasks
@JessicaMeixner-NOAA
Copy link
Collaborator

Close with merge of PR #888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aronroland @JessicaMeixner-NOAA @aliabdolali