Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OUTID: indexes outside of character array #487

Closed
MatthewMasarik-NOAA opened this issue Oct 5, 2021 · 2 comments · Fixed by #512
Closed

OUTID: indexes outside of character array #487

MatthewMasarik-NOAA opened this issue Oct 5, 2021 · 2 comments · Fixed by #512
Labels
bug Something isn't working

Comments

@MatthewMasarik-NOAA
Copy link
Collaborator

Describe the bug
The character array OUTID in w3wavemd is declared as length = 13, though is seen access index 15, where index variable J=8.

To Reproduce
Run the ww3_ufs1.1 regtest in debug mode (i.e., after running matrix_ncep, edit the run_test command string in matrix12 to have the compile flag/arg: -c intel_debug, then run matrix12).

Expected behavior
WW3 will compile successfully, but will crash with a forrtl: severe error as it starts to integrate at 00Z.

Screenshots
image

Additional context
N/A

@MatthewMasarik-NOAA MatthewMasarik-NOAA added the bug Something isn't working label Oct 5, 2021
@JessicaMeixner-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA since this is supposed to indicate writing a restart file, instead of having J=8 when determining the OUTID dimensions, I would vote going ahead and hard-coding that J value to 4 to write into the restart column. Alternatively the dimension of OUTID could be updated and we could add a new column for the second stream of restart writes. I don't know if others have preferences?

@MatthewMasarik-NOAA
Copy link
Collaborator Author

@JessicaMeixner-NOAA and I had an offline discussion, and the possibility of having both primary and secondary streams at the same time came up. If we hard-coded the J value to 4 in that case, two symbols would have to be at the same location. Based on this we thought / I'd vote for a new column to indicate secondary restarts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants