Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some output fields to RRFS #870

Merged
merged 15 commits into from
Feb 27, 2024

Conversation

EricJames-NOAA
Copy link
Contributor

@EricJames-NOAA EricJames-NOAA commented Feb 5, 2024

This PR addresses issue #770 and #773.

Add direct and diffuse solar irradiance to RRFS output, as well as some LSM related output that we need to produce (to match HRRR).

The new code was tested on Jet for RRFS_NA_3km system.

@FernandoAndrade-NOAA
Copy link
Collaborator

Hi @EricJames-NOAA, please be sure to create/link a git issue and add the appropriate entries in the changelogs within the sorc/ files updated, thank you!

@EricJames-NOAA
Copy link
Contributor Author

Hi @EricJames-NOAA, please be sure to create/link a git issue and add the appropriate entries in the changelogs within the sorc/ files updated, thank you!

@FernandoAndrade-NOAA thanks. I can't quite figure out how to link my github issue #773 to this PR....maybe I don't have permission to do that?

@FernandoAndrade-NOAA
Copy link
Collaborator

Hi @EricJames-NOAA, please be sure to create/link a git issue and add the appropriate entries in the changelogs within the sorc/ files updated, thank you!

@FernandoAndrade-NOAA thanks. I can't quite figure out how to link my github issue #773 to this PR....maybe I don't have permission to do that?

It would just be a section on the right labeled "Development" that should automatically close the issue upon PR merge, but you may be right it might be a permissions issue. I've gone ahead and added it manually thanks! For any future PRs, it's fine to just add a link within the PR description, thanks!

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Please sync your branch with the latest UPP develop branch and provide me the sample RRFS model output in netcdf for my testing.

@EricJames-NOAA
Copy link
Contributor Author

@WenMeng-NOAA we have some sample history files (9-h forecast) here on Hera:

/scratch1/BMC/wrfruc/mhu/temp/

Thanks!

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA My tests are at /scratch1/NCEPDEV/stmp2/Wen.Meng:
'''
post_rrfs_2024021416-before: test with the current develop branch

post_rrfs_2024021416-after: test with your branch
I verified all your proposed changes were generated in it.

Please verify my tests.

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Please sync your branch with the latest UPP develop branch again.

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. Baseline Change The baselines of the UPP regression tests are changed. labels Feb 23, 2024
@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs were completed on WCOSS2 and Hera. The baseline recreations are needed for fv3r and 3drtma with this PR.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. Please refer to my testing on Hera at /scratch1/NCEPDEV/stmp2/Wen.Meng. The datasets of NATLEV and PRSLEV in both fv3r and 3drtma have the following changes:

Records of NATLEV: 1570 -> 1648
Records of PRSLEV: 1078 -> 1090

@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA My tests are at /scratch1/NCEPDEV/stmp2/Wen.Meng: ''' post_rrfs_2024021416-before: test with the current develop branch

post_rrfs_2024021416-after: test with your branch I verified all your proposed changes were generated in it.

Please verify my tests.

Your results look consistent with mine! Thanks for your test!

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. Please refer to my testing on Hera at /scratch1/NCEPDEV/stmp2/Wen.Meng. The datasets of NATLEV and PRSLEV in both fv3r and 3drtma have the following changes:

Records of NATLEV: 1570 -> 1648
Records of PRSLEV: 1078 -> 1090

Hera is still in queue. It likely won't finish until tomorrow. My Orion results seem to match with yours:

1648 records for NATLEV within fv3r and 3drtma
1103 records for PRSLEV within rtma
1090 records for PRSLEV within fv3r

Hercules is unfortunately running into improper file generation again. We'll track that in a separate issue. I'll update here with the Hera results tomorrow.

@WenMeng-NOAA WenMeng-NOAA linked an issue Feb 27, 2024 that may be closed by this pull request
@FernandoAndrade-NOAA
Copy link
Collaborator

Hera has finished RTs as well with the expected record count changes within NATLEV and PRSLEV for fv3r and 3drtma. @WenMeng-NOAA FYI

@FernandoAndrade-NOAA
Copy link
Collaborator

@WenMeng-NOAA Are the changelog comment additions to INITPOST and SRFCE sufficient for ALLOCATE and DEALLOCATE or do we need an additional commit for those as well?

@WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA Are the changelog comment additions to INITPOST and SRFCE sufficient for ALLOCATE and DEALLOCATE or do we need an additional commit for those as well?

@FernandoAndrade-NOAA The subroutines ALLOCATE and DEALLOCATE are for variable allocation and deallocation.

@WenMeng-NOAA Are the changelog comment additions to INITPOST and SRFCE sufficient for ALLOCATE and DEALLOCATE or do we need an additional commit for those as well?

The change logs in INITPOST_NETCDF.f and SURFCE.f would be sufficient.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 74d4a19 into NOAA-EMC:develop Feb 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
3 participants