-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some output fields to RRFS #870
Conversation
Hi @EricJames-NOAA, please be sure to create/link a git issue and add the appropriate entries in the changelogs within the sorc/ files updated, thank you! |
@FernandoAndrade-NOAA thanks. I can't quite figure out how to link my github issue #773 to this PR....maybe I don't have permission to do that? |
It would just be a section on the right labeled "Development" that should automatically close the issue upon PR merge, but you may be right it might be a permissions issue. I've gone ahead and added it manually thanks! For any future PRs, it's fine to just add a link within the PR description, thanks! |
@EricJames-NOAA Please sync your branch with the latest UPP develop branch and provide me the sample RRFS model output in netcdf for my testing. |
@WenMeng-NOAA we have some sample history files (9-h forecast) here on Hera: /scratch1/BMC/wrfruc/mhu/temp/ Thanks! |
@EricJames-NOAA My tests are at /scratch1/NCEPDEV/stmp2/Wen.Meng: post_rrfs_2024021416-after: test with your branch
|
@EricJames-NOAA Please sync your branch with the latest UPP develop branch again. |
The UPP RTs were completed on WCOSS2 and Hera. The baseline recreations are needed for fv3r and 3drtma with this PR. |
@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. Please refer to my testing on Hera at /scratch1/NCEPDEV/stmp2/Wen.Meng. The datasets of NATLEV and PRSLEV in both fv3r and 3drtma have the following changes:
|
Your results look consistent with mine! Thanks for your test! |
Hera is still in queue. It likely won't finish until tomorrow. My Orion results seem to match with yours:
Hercules is unfortunately running into improper file generation again. We'll track that in a separate issue. I'll update here with the Hera results tomorrow. |
Hera has finished RTs as well with the expected record count changes within NATLEV and PRSLEV for fv3r and 3drtma. @WenMeng-NOAA FYI |
@WenMeng-NOAA Are the changelog comment additions to INITPOST and SRFCE sufficient for ALLOCATE and DEALLOCATE or do we need an additional commit for those as well? |
@FernandoAndrade-NOAA The subroutines ALLOCATE and DEALLOCATE are for variable allocation and deallocation.
The change logs in INITPOST_NETCDF.f and SURFCE.f would be sufficient. |
This PR is ready for merging. |
This PR addresses issue #770 and #773.
Add direct and diffuse solar irradiance to RRFS output, as well as some LSM related output that we need to produce (to match HRRR).
The new code was tested on Jet for RRFS_NA_3km system.