Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDASApp paths in global-workflow jobs have moved paths #991

Closed
aerorahul opened this issue Mar 24, 2024 · 5 comments
Closed

GDASApp paths in global-workflow jobs have moved paths #991

aerorahul opened this issue Mar 24, 2024 · 5 comments
Assignees

Comments

@aerorahul
Copy link
Contributor

An example here is prepsnowobs.sh

The line:

gdasappPATH="${HOMEgfs}/sorc/gdas.cd/iodaconv/src:${HOMEgfs}/sorc/gdas.cd/build/lib/python3.7"

The directory gdas.cd/iodaconv does not exist.
The python version (on Hera where this is seen) is not 3.7; it is 3.10.

This is likely going to cause an issue in all gdasapp jobs that have hard-wired python versions.

@RussTreadon-NOAA
Copy link
Contributor

RussTreadon-NOAA commented Mar 25, 2024

This issue will be addressed in RussTreadon-NOAA:feature/hera_r8_cleanup

The above statement is incorrect and therefore struck out. Resolution of this issue needs to be done in a g-w fork, not GDASApp.

@RussTreadon-NOAA
Copy link
Contributor

I am mistaken in my rush to resolve this issue. The valid points raised in this issue need to be resolved in the global-workflow repository, not GDASApp.

prepsnowobs.sh is a g-w script. It is true that the GDASApp path to iodaconv has changed. Also, on Hera Rocky 8 we use python/3.10. Thus, for the cited example in jobs/rocoto/prepsnowobs.sh the correct gdasappPATH is

gdasappPATH="${HOMEgfs}/sorc/gdas.cd/sorc/iodaconv/src:${HOMEgfs}/sorc/gdas.cd/build/lib/python3.10"

If we make this change, it needs to be made in g-w, not GDASApp.

@aerorahul , do you have a g-w version of this issue?

@RussTreadon-NOAA
Copy link
Contributor

Seems this issue may be closed. Do you agree @aerorahul?

@aerorahul
Copy link
Contributor Author

aerorahul commented Jan 10, 2025

prepsnowobs.sh is gone.
prepatmiodaobs.sh has an updated PYTHONPATH with pyiodaPATH that detects the python version.
So, I think we can close this.

@aerorahul
Copy link
Contributor Author

Was resolved by NOAA-EMC/global-workflow#2435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants