Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use evap from atm #96

Merged

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Jun 28, 2023

Allow CMEPs to use evaporative flux directly from ATM.

Description of changes

Instead of converting from latent heat to evaporative flux in prep_ocn_custom_nems, use the evaporative flux from the ATM directly.

This is part of the resolution of Issue #93. I want to commit this change as an incremental change since it was found to change baselines due to initial roundoff-level differences which then grow.

Testing performed

Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing

Testing results will be shown in the associated UFS issue ufs-community/ufs-weather-model#1812

* atm sends evap directly
Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me along with the updates in FV3.

@DeniseWorthen DeniseWorthen merged commit 9923d6d into NOAA-EMC:emc/develop Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants