forked from ESCOMP/CMEPS
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update CMEPS #82
Merged
DeniseWorthen
merged 287 commits into
NOAA-EMC:emc/develop
from
DeniseWorthen:feature/updcmeps
Feb 1, 2023
Merged
update CMEPS #82
DeniseWorthen
merged 287 commits into
NOAA-EMC:emc/develop
from
DeniseWorthen:feature/updcmeps
Feb 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description of changes Correct replacement of MODEL with COMP_NAME in buildexe. Specific notes Fixes ESCOMP#281 Contributors other than yourself, if any: CMEPS Issues Fixed (include github issue #): Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) Any User Interface Changes (namelist or namelist defaults changes)? Testing performed Testing performed if application target is CESM: (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py machines: cheyenne details (e.g. failed tests): (recommended) CESM testlist_drv.xml machines and compilers: details (e.g. failed tests): (optional) CESM prealpha test machines and compilers details (e.g. failed tests): (other) please described in detail machines and compilers details (e.g. failed tests): Build case SMS_D.f09_t061.B1850MOM.cheyenne_intel Testing performed if application target is UFS-coupled: (recommended) UFS-coupled testing description: details (e.g. failed tests): Testing performed if application target is UFS-HAFS: (recommended) UFS-HAFS testing description: details (e.g. failed tests): Hashes used for testing: CESM: repository to check out: ESCOMP/CESM.git branch/hash: UFS-coupled, then umbrella repostiory to check out and associated hash: repository to check out: branch/hash: UFS-HAFS, then umbrella repostiory to check out and associated hash: repository to check out: branch/hash:
### Description of changes Update shr_pio_mod, removing mct centric initialization. Improve logging and make sure logs go to the correct component. Depends on cime branch async_io_in_esmf ### Specific notes Contributors other than yourself, if any: CMEPS Issues Fixed (include github issue #): Are changes expected to change answers? bfb Any User Interface Changes (namelist or namelist defaults changes)? The modelio namelist has been eliminated and the parameters from that file were moved to nuopc.runconfig, The xml variable PIO_ASYNC_INTERFACE was changed from a global variable to one that could be set individually for each component. ### Testing performed Testing performed if application target is CESM: - [X] (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py - machines: cheyenne intel - details (e.g. failed tests): IRT_N2_Vmct_Ln9.f19_g16_rx1.A.cheyenne_intel fails, apparently expected. - [ ] (recommended) CESM testlist_drv.xml - machines and compilers: - details (e.g. failed tests): - [x] (optional) CESM prealpha test - machines and compilers - details (e.g. failed tests): - [ ] (other) please described in detail - machines and compilers - details (e.g. failed tests): Testing performed if application target is UFS-coupled: - [ ] (recommended) UFS-coupled testing - description: - details (e.g. failed tests): Testing performed if application target is UFS-HAFS: - [ ] (recommended) UFS-HAFS testing - description: - details (e.g. failed tests): ### Hashes used for testing: - [ ] CESM: - repository to check out: https://github.com/ESCOMP/CESM.git - branch/hash: - [ ] UFS-coupled, then umbrella repostiory to check out and associated hash: - repository to check out: - branch/hash: - [ ] UFS-HAFS, then umbrella repostiory to check out and associated hash: - repository to check out: - branch/hash:
…ternalstate (ESCOMP#279) Refactors esmFldsExchange_nems.F90 to use separate advertise and initialize phases and to check that a component is present before advertising a field to or from that component. Implements default src and dst mask values in place of the code currently in med_map_mod.F90. Fixes NOAA-EMC#63 and NOAA-EMC#64.
This was done so that vertical component used in grid name does not affect tests.
need to initialize these variables
replace use of master with main
redo multiinstance support
update esmFldsExchange_nems for ungridded wave fields; fix incorrect units in mediator files
37 tasks
junwang-noaa
approved these changes
Jan 25, 2023
* add message when reading restart fails because first field does not exist
BrianCurtis-NOAA
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update from ESCOMP/main, add coordinate fix for mediator files. Also add error message for restart file reading.
Specific notes
Updates from ESCOMP includes removal of un-used variables and removal of references to "master".
-fixes #81
-fixes #83
See UWM ufs-community/ufs-weather-model#1570 for details of testing.