Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline build of Parallel IO. Use PIO as an external dependency. #16

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Remove inline build of Parallel IO. Use PIO as an external dependency. #16

merged 2 commits into from
Sep 30, 2020

Conversation

aerorahul
Copy link

Description of changes

This PR:

  • removes the git submodule of ParallelIO
  • Depends on externally built parallel IO. It is referenced via the environment variable PIO_ROOT, and follows standard installation structure include/ and lib/

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

  • (required) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (required) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-S2S:

  • (required) UFS-S2S testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. The PR needs to be committed with s2s ESCOMP#199 after s2s RT tests are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants