Update CDEPS #58
Merged
Update CDEPS #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in this initial commit, it is just a copy of CORE2-NYF.
cdeps1.0.10
Remove the tabs in the datm buildnml
Update stream definitions for new coupler history file format ### Description of changes Modify stream_definition_datm.xml to generate a streams file (datm.streams.xml) with the new coupler history file format. ### Specific notes Changes to accommodate new coupler history file names. Change offset for solar stream from 2700 to -900 to accommodate changes due to time stamps. These changes work in conjunction with CDEPS PR ESCOMP#224 and CDEPS PR ESCOMP#222 . Note that I did not change the file names for ndep, or remove that stream. See ESCOMP#230 Contributors other than yourself, if any: @billsacks CDEPS Issues Fixed (include github issue #): N/A Are there dependencies on other component PRs (if so list): No Are changes expected to change answers (bfb, different to roundoff, more substantial): Yes, in coupler history mode. Any User Interface Changes (namelist or namelist defaults changes): No Testing performed (e.g. aux_cdeps, CESM prealpha, etc): I have conducted a pair of cases, an F-case to generate coupler history files, and an I-case to read those files, using the new file name convention, and compared the forcing output variables from clm history files between the two cases. @billsacks and I reviewed these differences and found them to be acceptable. @billsacks ran SMS_D_Ld1.ne30pg3_t061.I1850Clm50BgcSpinup.cheyenne_intel.clm-cplhist in the context of ESCOMP/CTSM#1999 Hashes used for testing: N/A
black reformat these python files
update github to make cdeps ext build an action
Update SST files for historical configurations
update esmf bld to use official esmf action
Simple fix for buildlib python bug ### Description of changes As laid out in ESCOMP#240 a bug was found in the [buildlib script](https://github.com/ESCOMP/CDEPS/blob/f7e657e6f0ad2e758534b0e2cd195f18e8f08ecc/cime_config/buildlib#L182) This code update changes the `append` line to a string concatenation and updates the `if "F90" in line and not "fox" in line:` line to ensure different capitalizations of "fox" don't slip through. Contributors other than yourself, if any: @billsacks CDEPS Issues Fixed (include github issue #): ESCOMP#240 Are there dependencies on other component PRs (if so list): No Are changes expected to change answers (bfb, different to roundoff, more substantial): No Any User Interface Changes (namelist or namelist defaults changes): No Testing performed (e.g. aux_cdeps, CESM prealpha, etc): Tested manually with `SMS_D_Ld1_P8x1.f10_f10_mg37.I2000Clm50BgcCropQianRs.fleabone_gnu.clm-default` (on personal computer) Hashes used for testing: `cdeps1.0.13-1-gd31de60`
…ized forcing controlled via nml params
Simple DATM forcing mode
add namelist lookup to each namelist read call
fix minor typo in drof modifier mode
allow path changes and symlinks in stream filenames
|
@binli2337 Can you merge this pr? All tests were done at weather model side. |
|
@junwang-noaa @DeniseWorthen can you merge this pr? |
|
I cannot merge in this repo. |
|
@binli2337 thanks for merging this pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update CDEPS to support new data atmosphere configurations (with ERA5) of component land model.