-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only set complevel for compressed float vars #162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in current netcdf-c, it errors if you try to apply to a variable- length dtype variable (such as string vars with object dtype)
@colin-harkins we may have to do this in |
to serve as test
when it runs in order, it is giving this huge labels now, weird
I guess it used to be an implicit dep of someone or something?
@colin-harkins I think this is ready for you to take a look. I added some links and such to your example nbs. |
colin-harkins
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zmoon This looks good to me, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We first noticed this in #160
In current netcdf-c (v4.9.1 when first noticed), it errors if you set compression for a variable-length dtype variable (such as string arrays with NumPy
object
dtype). With this PR, we only set compression for float vars.See:
Summary:
write_ncf
, only supplycomplevel
for float varscomplevel
for float vars inwrite_analysis_ncf