Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLog AppTriming Exercise #4297

Closed
snakefoot opened this issue Feb 12, 2021 · 3 comments
Closed

NLog AppTriming Exercise #4297

snakefoot opened this issue Feb 12, 2021 · 3 comments

Comments

@snakefoot
Copy link
Contributor

snakefoot commented Feb 12, 2021

When adding NLog to an empty Console Application with NetCore5 and enables AppTriming, then it grows from single file of 10 MByte to 20 MByte.

Investigate what parts of NLog is causing this growth, and highlight those parts as obsolete for NLog 6.0.

This exercise should be done early (Ex NLog 5.1), to give time for people to adjust for things becoming obsolete.

Did try to remove all targets and all layoutrenderers, and still the AppTriming size only dropped very little. Then tried to just have NLog InternalLogger and then the size dropped as expected.

@snakefoot
Copy link
Contributor Author

But if NLog 6.0 will become the breaker of chains, then I guess this exercise might not be needed as it will happen automatically. See also #3366 (comment)

@snakefoot snakefoot modified the milestones: 5.0 (new), 6.0 May 19, 2021
@snakefoot
Copy link
Contributor Author

See also dotnet/runtimelab#1269

@snakefoot
Copy link
Contributor Author

Closing as duplicate of #3366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant