From 5406c5bc36dc5536753533f3fded64bc1e2a1471 Mon Sep 17 00:00:00 2001 From: Patrick Bos Date: Tue, 10 Dec 2024 20:50:11 +0100 Subject: [PATCH] fix links (#417) --- .github/workflows/link-checker-pr.yml | 2 +- .github/workflows/link-checker.yml | 2 +- best_practices/overview.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/link-checker-pr.yml b/.github/workflows/link-checker-pr.yml index 527ec8d..7e9a47b 100644 --- a/.github/workflows/link-checker-pr.yml +++ b/.github/workflows/link-checker-pr.yml @@ -35,4 +35,4 @@ jobs: - name: Check all this file's additions for broken links run: | export base_sha=$(git rev-parse ${{ github.sha }}^) - git diff -U0 ${base_sha} ${{ github.event.pull_request.head.sha }} -- ${{ matrix.file }} | grep -v "+++" | grep "^+" | cut -c 2- | ./lychee --exclude nlesc.sharepoint.com --exclude support.posit.co --exclude www.intel.com - + git diff -U0 ${base_sha} ${{ github.event.pull_request.head.sha }} -- ${{ matrix.file }} | grep -v "+++" | grep "^+" | cut -c 2- | ./lychee --exclude nlesc.sharepoint.com --exclude support.posit.co --exclude www.intel.com --exclude reddit.com - diff --git a/.github/workflows/link-checker.yml b/.github/workflows/link-checker.yml index fc446f1..badf569 100644 --- a/.github/workflows/link-checker.yml +++ b/.github/workflows/link-checker.yml @@ -16,7 +16,7 @@ jobs: id: lychee with: # note: args has a long default value; when you override it, make sure you don't accidentally forget to include the default options you want! see https://github.com/lycheeverse/lychee-action/blob/master/action.yml - args: --verbose --no-progress './**/*.md' './**/*.html' './**/*.rst' --accept '100..=103,200..=299, 429' --exclude nlesc.sharepoint.com --exclude support.posit.co --exclude www.intel.com + args: --verbose --no-progress './**/*.md' './**/*.html' './**/*.rst' --accept '100..=103,200..=299, 429' --exclude nlesc.sharepoint.com --exclude support.posit.co --exclude www.intel.com --exclude reddit.com env: # This token is included to avoid github.com requests to error out with status 429 (too many requests). It only works for GitHub requests (also other GitHub REST API calls), not for the rest of the web. GITHUB_TOKEN: ${{secrets.TOKEN_GITHUB}} diff --git a/best_practices/overview.md b/best_practices/overview.md index 68413e3..dd146c2 100644 --- a/best_practices/overview.md +++ b/best_practices/overview.md @@ -80,7 +80,7 @@ The Turing Way offers many related tips in their [chapter on Making Research Obj ## Packaging A related, but separate topic is packaging, which allows users to conveniently install your released software. -Most [languages](language_guides/languages_overview) and OS'es have their particular ways of doing this. +Most [languages](/language_guides/languages_overview) and OS'es have their particular ways of doing this. The Turing Way offers advice on [making reproducible environments](https://book.the-turing-way.org/reproducible-research/renv), in which packaging is an essential component. ## Know your tools