Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect metadata for the decompmicc parameter #793

Closed
rgknox opened this issue Oct 6, 2021 · 0 comments · Fixed by #792
Closed

incorrect metadata for the decompmicc parameter #793

rgknox opened this issue Oct 6, 2021 · 0 comments · Fixed by #792

Comments

@rgknox
Copy link
Contributor

rgknox commented Oct 6, 2021

See the metadata describing the decompmicc parameter here:

https://github.com/NGEET/fates/blob/master/parameter_files/fates_params_default.cdl#L168-L170

It states the value should be the mean, but this is not true. The value should actually be the maximum amount found over the depth of the soil column, and then the code will apply an exponential attenuation function to it. The maximum from the parameter file will be applied at a hard coded 7cm of depth with a similarly hard-coded attenuation coefficient, which were designed to match previous decomposition profiles provided by @qzhu-lbl in the ELM parameter file.

See here:
https://github.com/NGEET/fates/blob/master/biogeochem/FatesSoilBGCFluxMod.F90#L680-L687

@jenniferholm @qzhu-lbl

@rgknox rgknox mentioned this issue Oct 6, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant