Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: modal): fix maskClosable not work #722

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

tirelyl
Copy link
Collaborator

@tirelyl tirelyl commented Jul 5, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
#720

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@tirelyl tirelyl requested a review from fisherspy July 5, 2020 07:01
@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #722 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #722   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files         164      164           
  Lines        6747     6747           
  Branches     1104     1104           
=======================================
  Hits         5881     5881           
  Misses        421      421           
  Partials      445      445           
Impacted Files Coverage Δ
components/modal/modal.component.ts 78.43% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2748f0...77ba553. Read the comment docs.

@fisherspy fisherspy merged commit 8aae09b into NG-ZORRO:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants