Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MusicPlayer/Volume #153

Open
tmrobert8 opened this issue Nov 5, 2018 · 1 comment
Open

MusicPlayer/Volume #153

tmrobert8 opened this issue Nov 5, 2018 · 1 comment

Comments

@tmrobert8
Copy link

According to the doc, the music player type requires volume/mute. Is there any chance to make that optional (and if not specified, revert to the auto wiring to have a TV/AVR as the volume source)?

I ask that because some music players (Kaleidescape being one of them) depend on an external device for volume...

@pfiaux
Copy link
Contributor

pfiaux commented Nov 5, 2018

That's a good point, making it optional is one thing i guess that goes in the lines of #113.

Using the other devices is a bit more tricky because it will depend on the type of device implementing the player:

  • Any player could have it's own volume control
  • A player implemented by a "wireable" device (DVD,BluRay,...) could fall back on the other devices (it these do not have dedicated sensors it might be similar to IR where we don't know if mute is on or off)
  • A player by a non wireable device (musicplayer, accessory, ...) would not be able to use another device, so needs a UI with no volume/mute control

It's also related to #118 about making the player UI more flexible. Maybe we'll regroup the issues into one later to have a better overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants