Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Data dump and load serialisations #392

Merged
merged 2 commits into from
Apr 26, 2022
Merged

dask: Data dump and load serialisations #392

merged 2 commits into from
Apr 26, 2022

Conversation

davidhassell
Copy link
Collaborator

No description provided.

@davidhassell davidhassell added the dask Relating to the use of Dask label Apr 25, 2022
@davidhassell davidhassell mentioned this pull request Apr 25, 2022
Closed
sadielbartholomew
sadielbartholomew reviewed Apr 26, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, though I had one question which may provoke further changes, as below.

  • I see that the loadd=None and loads=None keywords remain, along with basic necessary management of those (if loadd is not None: statement and the equivalent), in the constructor method for the Data object. Is there a reason they have been left in, or can they now be cut too (I suspect they have been missed since they will throw an error as-is for this PR, I believe)?

@davidhassell
Copy link
Collaborator Author

Good spot - those keywords and their associated code have gone: ed0683d

sadielbartholomew
sadielbartholomew approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sanity checked the new commit and this is ready to go. Thanks.

@davidhassell davidhassell merged commit 623ea40 into NCAS-CMS:lama-to-dask Apr 26, 2022
@davidhassell davidhassell deleted the dask-dump-load branch November 15, 2022 09:26
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew