-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dask: Data.unique
#391
dask: Data.unique
#391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good and ready to merge, with a nice extension to the unit test, though if I was to be harsh I might suggest first including also in the unit test a small block to cover the various data type possibilities ("fibUS"
as set here) and in particular the case of a string-type data array, an example I checked manually in reviewing, since really we are only checking integer arrays at present?).
Harsh is fine! Data type unit tests: ae13c20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonus points for adding the new commit, which I have sanity checked and has added my suggestion in an elegant way. All good to merge.
For future reference - the |
No description provided.