-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dask: Data
collapse methods and functions
#356
dask: Data
collapse methods and functions
#356
Conversation
Hang on - forgot a test .... |
OK - good to go. |
Another note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm mid-way through reviewing and everything seems good so far. Thought I'd raise some typos in the meantime, and if you can address the conflict resolutions that would help me to ensure I am reviewing the up-to-date code. Thanks.
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
…on into dask-collapse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is fantastic. The updated code is well-structured and even copes sensibly across all of the statistics (bar those two methods you say are out-of-scope for this PR) for the slightly evil case of a fully-masked array. Great commitment to thorough documentation, too.
I've posed a few questions on minor aspects and suggested fixes for inevitable typos, one of which is in the functional code so is quite crucial to update. Thanks.
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Another hefty PR! Hopefully self explanatory, but these notes might be useful:
Data.square
andData.sqrt
because they were useful.Data.stats
andData.mean_of_upper_decile
before realising that they can't be tested yet. So these will be dealt with in separate PRs. Feel free to ignore these methods.