Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Data.convolution_filter #294

Merged
merged 3 commits into from
Jan 11, 2022
Merged

dask: Data.convolution_filter #294

merged 3 commits into from
Jan 11, 2022

Conversation

davidhassell
Copy link
Collaborator

No description provided.

@davidhassell davidhassell added the dask Relating to the use of Dask label Jan 5, 2022
@davidhassell
Copy link
Collaborator Author

Note: I changed the cfdm version to >= 1.9.0.1, as a convenience for my environment - I don't think that there are any knock-on effects from this ....

sadielbartholomew
sadielbartholomew approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect: works, with updated testing, and is very thoroughly commented. Thanks!

@sadielbartholomew
Copy link
Member

Note: I changed the cfdm version to >= 1.9.0.1, as a convenience for my environment - I don't think that there are any knock-on effects from this ....

No code-level effects though it does break the CI jobs because they are set to install the previous version specifically. Just to be rigorous I'll push a reversion of the version and re-trigger the CI jobs now. The test_Data module passes locally for me but it is always nice to check everything works across each environment as we go...

@sadielbartholomew
Copy link
Member

Opening and closing to re-trigger to CI jobs...

@sadielbartholomew
Copy link
Member

Clean sweep of passes, so I'll merge now and update the grand table...

@sadielbartholomew sadielbartholomew merged commit 4c28c43 into NCAS-CMS:lama-to-dask Jan 11, 2022
@sadielbartholomew sadielbartholomew mentioned this pull request Jan 11, 2022
Closed
@davidhassell davidhassell deleted the dask-convolution-filter branch November 15, 2022 09:12
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew