Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support binary operations e.g. arctan2 division #38

Open
sadielbartholomew opened this issue Feb 28, 2020 · 0 comments
Open

Support binary operations e.g. arctan2 division #38

sadielbartholomew opened this issue Feb 28, 2020 · 0 comments
Labels
API review (4.0.0) enhancement New feature or request

Comments

@sadielbartholomew
Copy link
Member

(Summarising DH/SB discussions today) element-wise binary operations i.e. operations combining two operands, are not trivial to implement with LAMA, unlike unary operations which are so & are already handled via LAMA in the codebase. We decided to think about & investigate efficient means to partition element-wise binary operations with LAMA towards adding logic to do so for a version after the imminent 3.2.0, ideally 3.3.0.

In particular, I recently implemented (fully except for LAMA management) the two-argument inverse tangent method arctan2(y, x) which takes two data arrays as inputs and as a first step takes the element-wise quotient. As this needs such two-input LAMA logic, I have commented it out (tagged with AT2) pending that, so arctan2 i.e. division would be the natural case for experimentation.

We can then as appropriate add in further binary methods, though a different LAMA strategy could perhaps optimise (serially) any one case.

@sadielbartholomew sadielbartholomew added the enhancement New feature or request label Feb 28, 2020
@sadielbartholomew sadielbartholomew added this to the 3.3.0 milestone Feb 28, 2020
@sadielbartholomew sadielbartholomew changed the title LAMA partitioning for binary operations (e.g. arctan2 division) Binary operation (e.g. arctan2 division) LAMA partitioning Feb 28, 2020
@davidhassell davidhassell removed this from the 3.3.0 milestone Nov 16, 2022
@sadielbartholomew sadielbartholomew changed the title Binary operation (e.g. arctan2 division) LAMA partitioning Support binary operations e.g. arctan2 division Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API review (4.0.0) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants