Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/transition-to-capgen-1: update SDF syntax and XML schema, remove DDT dependency in radiation physics, correct units #64

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 6, 2020

Description

This PR contains

updated with the latest code in feature/transition-to-capgen-1. Additional changes:

  • update XML schema and syntax for all suite definition files; all SDFs validate against suite.xsd using xmllint

Testing

See NCAR/ufs-weather-model#65

Dependencies

NCAR/ccpp-physics#506
NCAR/ccpp-framework#327
#64
NCAR/ufs-weather-model#65

grantfirl and others added 17 commits August 13, 2020 16:06
…removal of GFS DDTs from ccpp physics (except for time_vary routines)
Copy link
Collaborator

@mzhangw mzhangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good/familiar. Thanks.

@climbfuji climbfuji force-pushed the update_xsd_and_sdfs_and_ddt_gfs_rad_removal branch from 52bfe36 to 48ab49f Compare October 7, 2020 16:44
@climbfuji climbfuji merged commit d429f87 into NCAR:feature/transition-to-capgen-1 Oct 7, 2020
SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/fv3atm that referenced this pull request Dec 25, 2020
* Perturb all chem emissions.

* Move emis_multiplier initialization back to gsdchem/gsd_chem_seas_wrapper.F90

* Perturb diagnostics too

* point to NOAA-GSL repo
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/fv3atm that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants