Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS/dev PR#34 (RRTMGP refactoring) #367

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

grantfirl
Copy link
Collaborator

update typedefs, SDFs, submodule pointers, and ccpp_prebuild_config.py to work with ccpp-physics ufs-dev/PR#34

@grantfirl
Copy link
Collaborator Author

ccpp_prebuild CI test fails due to known issue (flag_for_vertical_ordering_in_rrtmgp is accidentally used in RRTMGP and is fixed in NCAR/ccpp-physics#1001)

@grantfirl
Copy link
Collaborator Author

@dustinswales It looks like some RTs unexpectedly differ. How are we supposed to update the baselines again? I'm wondering if they just weren't updated from the last merged PR?

@dustinswales
Copy link
Collaborator

@dustinswales It looks like some RTs unexpectedly differ. How are we supposed to update the baselines again? I'm wondering if they just weren't updated from the last merged PR?

@grantfirl

ccpp_prebuild CI test fails due to known issue (flag_for_vertical_ordering_in_rrtmgp is accidentally used in RRTMGP and is fixed in NCAR/ccpp-physics#1001)

Correct, I changed flag_for_vertical_ordering_in_rrtmgp flag_for_vertical_ordering_in_radiaiton in ufs/dev #38

@dustinswales
Copy link
Collaborator

@dustinswales It looks like some RTs unexpectedly differ. How are we supposed to update the baselines again? I'm wondering if they just weren't updated from the last merged PR?

Yeah, it's the same two tests that differ from the last PR.
To update the baselines I upload the "github artifacts" to the DTC ftp site when they need updating (This is the only piece not controlled by CI, which I can't figure out how to automate).

@dustinswales dustinswales merged commit 524431f into NCAR:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants