Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GFS.v16.0.4 physics update #460

Merged
merged 4 commits into from
Jun 12, 2020
Merged

GFS.v16.0.4 physics update #460

merged 4 commits into from
Jun 12, 2020

Conversation

junwang-noaa
Copy link
Collaborator

@junwang-noaa junwang-noaa commented Jun 11, 2020 •
edited
Loading

GFS.v16.0.4 Physics updates include:

  1. Fixing a solar radiation bug in RRTMg
  2. Tuning in samfdeepcnv.f to increase maximum cloud-base mass flux
  3. Updates in vertical mixing in satmedmfvdifq.f
  4. Revert z0 change in sfc_diff.f

fv3atm #28
#460
ufs-weather-model #144

This was referenced Jun 11, 2020
Merged
Merged
climbfuji
climbfuji reviewed Jun 11, 2020
View reviewed changes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, thanks very much for bringing over the GFS v16 updates. Have you tested that the CCPP code gives the same results as the IPD code (in REPRO mode)?

@junwang-noaa
Copy link
Collaborator Author

These changes look good to me, thanks very much for bringing over the GFS v16 updates. Have you tested that the CCPP code gives the same results as the IPD code (in REPRO mode)?

Not yet, I am creating new baseline.

@climbfuji climbfuji merged commit 571ff99 into NCAR:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climbfuji climbfuji climbfuji approved these changes

@grantfirl grantfirl Awaiting requested review from grantfirl

@JulieSchramm JulieSchramm Awaiting requested review from JulieSchramm

@llpcarson llpcarson Awaiting requested review from llpcarson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junwang-noaa @climbfuji