Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined version of HAFS/GFS moninedmf scheme (hybrid EDMF PBL) #395

Closed
wants to merge 10 commits into from

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Feb 6, 2020

This PR combines the HAFS and GFS versions of moninedmf.f. The HAFS version is activated with the 'hurr_pbl' namelist variable set to true. The moninq_fac (AKA alpha) parameter is also a namelist variable and should be set to -1.0.

All sections that are different for the HAFS version should be executed within IF statements that check for whether hurr_pbl is true.

@grantfirl
Copy link
Collaborator Author

… argument list (specifically grav and cp) causes regression test failures in PROD mode
@climbfuji
Copy link
Collaborator

climbfuji commented Apr 7, 2020

This PR was merged into the dtc/hwrf-physics branch in PR #428. It didn't change the answer for the existing tests and can thus be merged into the master or dtc/develop branch when needed.

An additional change was needed (hidden in one of the update from dtc/develop commits), see commit b492f72

@climbfuji
Copy link
Collaborator

This PR has been merged into dtc/hwrf-physics (see #428) and will be merged into master in the future, when all changes in dtc/hwrf-physics are merged back.

@climbfuji climbfuji closed this Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants