Surface upward heat fluxes for coupling are not properly calculated when (cplaqm .and. .not.cplflx) is ture in GFS_PBL_generic_post.F90

[ChunxiZhang-NOAA]

Description

In GFS_PBL_generic_post.F90, when AQM model is on and condition (cplaqm .and. .not. cplflx) is true, the model will crash due to unallocated variables dtsfc_cice and dqsfc_cice in GFS_typedefs.F90 (dtsfcin_cpl and dqsfcin_cpl accordingly). The following is the slice of the code:

if (cplaqm .and. .not.cplflx) then
do i=1,im
if (oceanfrac(i) > zero) then ! Ocean only, NO LAKES
if ( .not. wet(i)) then ! no open water
if (kdt > 1) then !use results from CICE
dtsfci_cpl(i) = dtsfc_cice(i)
dqsfci_cpl(i) = dqsfc_cice(i)
else !use PBL fluxes when CICE fluxes is unavailable
dtsfci_cpl(i) = dtsfc1(i)hffac(i)
dqsfci_cpl(i) = dqsfc1(i)
end if
elseif (icy(i) .or. dry(i)) then ! use stress_ocean from sfc_diff for opw component at mixed point
rho = prsl(i,1) / (rdt1(i)(one+fvirtmax(q1(i), qmin)))
dtsfci_cpl(i) = cp * rho * hflx_wat(i) ! sensible heat flux over open ocean
dqsfci_cpl(i) = hvap * rho * evap_wat(i) ! latent heat flux over open ocean
else ! use results from PBL scheme for 100% open ocean
dtsfci_cpl(i) = dtsfc1(i)*hffac(i)
dqsfci_cpl(i) = dqsfc1(i)
endif
endif ! Ocean only, NO LAKES
enddo
end if

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. step 1
2. step 2
3. see the bug...

Additional Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

• Machine
• Compiler
• Suite Definition File or Scheme
• Reference other issues or PRs in other repositories that this is related to, and how they are related.

Output

Please include any relevant log files, screenshots or other output here.

[bbakernoaa]

Has there been a PR submitted for this? @ChunxiZhang-NOAA

[ChunxiZhang-NOAA]

@bbakernoaa No, I haven't submitted a PR for this issue. I will submit one soon.

[bbakernoaa]

Ok This is a big issue for the development of the Online-CMAQ. Let's do what we can to push this faster. Barry Baker National Oceanic and Atmospheric Administration Air Resources Laboratory Physical Research Scientist Chemical Modeling and Emissions Group Leader NCWCP, R/ARL, Rm. 4204 5830 University Research Court College Park, Maryland 20740 Phone: ‪(301) 683-1395‬

…

On Fri, Aug 12, 2022 at 11:37 AM ChunxiZhang-NOAA ***@***.***> wrote: @bbakernoaa <https://github.com/bbakernoaa> No, I haven't submitted a PR for this issue. I will submit one soon. — Reply to this email directly, view it on GitHub <#945 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFIUVN3AMAHNN5ZKHXNIEB3VYZVULANCNFSM53I4K6TA> . You are receiving this because you were mentioned.Message ID: ***@***.***>