Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preprocessor directives looking for CCPP from Noah MP source code #543

Open
climbfuji opened this issue Jan 6, 2021 · 0 comments
Assignees

Comments

@climbfuji
Copy link
Collaborator

climbfuji commented Jan 6, 2021

When NoahMP was ported to CCPP, a decision was made to add preprocessor directives #ifdef CCPP in order to keep both WRF and CCPP error handling routines in place. Given the discussion at yesterday's (01/05/2020) CCPP framework meeting, at which the NCAR side said that they will be looking forward to using the yet-to-come improved CCPP error handler in the future, we should get rid of those preprocessor directives and the WRF error handling routines.

Affected files:

physics/module_sf_noahmp_glacier.f90
physics/module_sf_noahmplsm.f90
physics/sfc_noahmp_drv.f

This should be done after @climbfuji's IPD cleanup PRs for the UFS (these will, as an intermediate solution, add #define CCPP to the top of each of these files, because the overall -DCCPP flags will be removed from the build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants