Adding an init & fini function pointer to the Suite. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the initial framework to call a suite's init and fini subroutines. This is only the xml parsing and saving the subroutine name to the ccpp_suite_t. Still need to add the ability to call those subroutines.
A suite can have an init and fini key words in the XML schema. This meant I re-worked how the XML is parsed and moved the element parsing into the ccpp_xml.f90 file (out of the ccpp_suite.f90). This reduces the ugliness of the suite init subroutine. The library keyword for the suite XML is now required. Also changed the STR_LEN to be CCPP_STR_LEN to be consistent with the CCPP naming convention.
The FV3 with the IPDv4 and GFS physics use 4 big derived data types. As a first step we'll use these IPD DDTs.
gold2718
added a commit
that referenced
this pull request
Mar 23, 2019
Code changes to make the converter work with GFS_typedefs.F90, in particular handle !defined(X) preprocessor statements. Also: changes to top-level convert_metadata.py script that defines the logger, partially overlapping with what @gold2718 just pushed a few minutes ago.
climbfuji
pushed a commit
to climbfuji/ccpp-framework
that referenced
this pull request
Nov 19, 2020
…in_init_and_finalize Support "unblocked" variables in init and finalize
peverwhee
pushed a commit
that referenced
this pull request
Nov 7, 2023
Add new water species constituent property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to have optional init and fini function pointer elements in a suite xml. These allow for arbitrary subroutines (in the same way a scheme element does) to be used for suite initialization and finalization.
It is preliminary work to enable FV3 and IPDv4/GFS-Physics integration.