-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
needed for HWRF NOAH LSM #280
Conversation
…riable within CMakeLists.txt when building with the SCM
Associated PRs: |
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
=======================================
Coverage 47.28% 47.28%
=======================================
Files 14 14
Lines 1343 1343
=======================================
Hits 635 635
Misses 708 708 Continue to review full report at Codecov.
|
If we need to synchronize the associated PRs with this one going to master, then this will take a bit of time. Not sure exactly when we will be able to commit to EMC develop / NCAR master next. If this takes too long, it may be better to create a dtc/hwrf-physics branch based on master in the meanwhile. |
Should we direct this PR to dtc/hwrf-physics? We need the code there to
start testing.
…On Wed, Apr 8, 2020 at 8:51 PM Dom Heinzeller ***@***.***> wrote:
If we need to synchronize the associated PRs with this one going to
master, then this will take a bit of time. Not sure exactly when we will be
able to commit to EMC develop / NCAR master next. If this takes too long,
it may be better to create a dtc/hwrf-physics branch based on master in the
meanwhile.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#280 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7WQAQ34Z4DL54D6W2FK73RLUZ2LANCNFSM4MEMLL2A>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Shows how sexy the unit converter is in that you just have to a couple of simple routines to get more conversions.
I can create a new branch dtc/hwrf-physics based on master and this PR in. Will do so now ... |
@grantfirl @llpcarson @ligiabernardet @mzhangw FYI - I created a new branch dtc/hwrf-physics for ccpp-framework and enabled branch protection for it. @grantfirl Would you please check out this branch in FV3/ccpp/framework for your PRs listed above? The hash should be It is ok for the RRTMG PRs to go in as they are without pointing to this new branch, since they don't require the updates to ccpp-framework. The switch will be made when Grant's PRs go in afterwards (they need to be updated after RRTMG merge anyway for rerunning the regression tests). |
The cmake policy #77 change is already in dtc/develop, but not in master. The cm-to-m conversion is straightforward.