Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needed for HWRF NOAH LSM #280

Merged
merged 4 commits into from
Apr 17, 2020
Merged

needed for HWRF NOAH LSM #280

merged 4 commits into from
Apr 17, 2020

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Apr 9, 2020

The cmake policy #77 change is already in dtc/develop, but not in master. The cm-to-m conversion is straightforward.

@grantfirl
Copy link
Collaborator Author

@codecov-io
Copy link

Codecov Report

Merging #280 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   47.28%   47.28%           
=======================================
  Files          14       14           
  Lines        1343     1343           
=======================================
  Hits          635      635           
  Misses        708      708           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32b965...19ff305. Read the comment docs.

@climbfuji
Copy link
Collaborator

If we need to synchronize the associated PRs with this one going to master, then this will take a bit of time. Not sure exactly when we will be able to commit to EMC develop / NCAR master next. If this takes too long, it may be better to create a dtc/hwrf-physics branch based on master in the meanwhile.

@ligiabernardet
Copy link
Collaborator

ligiabernardet commented Apr 9, 2020 via email

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shows how sexy the unit converter is in that you just have to a couple of simple routines to get more conversions.

@climbfuji
Copy link
Collaborator

Should we direct this PR to dtc/hwrf-physics? We need the code there to start testing.

I can create a new branch dtc/hwrf-physics based on master and this PR in. Will do so now ...

@climbfuji
Copy link
Collaborator

@grantfirl @llpcarson @ligiabernardet @mzhangw FYI - I created a new branch dtc/hwrf-physics for ccpp-framework and enabled branch protection for it. @grantfirl Would you please check out this branch in FV3/ccpp/framework for your PRs listed above? The hash should be
4791b82. Then, update the .gitmodules file and submodule pointer for ccpp/framework in fv3atm. Thanks!

It is ok for the RRTMG PRs to go in as they are without pointing to this new branch, since they don't require the updates to ccpp-framework. The switch will be made when Grant's PRs go in afterwards (they need to be updated after RRTMG merge anyway for rerunning the regression tests).

@climbfuji climbfuji merged commit c0a9d84 into NCAR:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants