-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit converter does not handle a variable with units = 1 #458
Closed
gold2718 opened this issue
Dec 22, 2022
· 1 comment
· Fixed by #462, NOAA-EMC/fv3atm#634 or ufs-community/ufs-weather-model#1654
Closed
Unit converter does not handle a variable with units = 1 #458
gold2718 opened this issue
Dec 22, 2022
· 1 comment
· Fixed by #462, NOAA-EMC/fv3atm#634 or ufs-community/ufs-weather-model#1654
Labels
bug
For issues describing bugs, or PRs fixing bugs
Comments
This was referenced Dec 22, 2022
Fix implemented in #462 Old (bad) output:
After fix:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If the units converter is invoked because a variable is listed in metadata with the same standard name but a different unit and one of the units is
"1"
, an obscure error is generated as the units converter does not know how to handleunits = 1
.Steps to Reproduce
195ee07, no modifications
Please provide detailed steps for reproducing the issue.
1
units = 1
.Additional Context
The problem is that the unit converter attempts to convert each unit into a python identifier and
1
does not cooperate.The text was updated successfully, but these errors were encountered: