Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GHGcenter banner issues #1415

Open
snmln opened this issue Jan 29, 2025 · 3 comments
Open

[Bug] GHGcenter banner issues #1415

snmln opened this issue Jan 29, 2025 · 3 comments
Labels
P3 Place in the backlog so we don't lose track tech debt

Comments

@snmln
Copy link
Contributor

snmln commented Jan 29, 2025

GHGcenter banner icons not functioning correctly

Message context: The banner icons on the GHGC staging environment weren't loading properly when accessed through the /ghgcenter subpath. I suspect the issue might be related to the subpath configuration.
We attempted a quick workaround by prefixing the paths with /ghgcenter, but this didn't fully resolve the issue—specifically, the US flag icon still didn't show up.

URL: US-GHG-Center/veda-config-ghg#711

Blocking a release? (y/n): n

Regression issue? (y/n):
[If yes, add Regression label]

Priority: P3

@snmln snmln added P3 Place in the backlog so we don't lose track tech debt labels Jan 29, 2025
@dzole0311
Copy link
Collaborator

@snmln Is this only happening when deployed to earth.gov/ghgcenter? Because if i open https://earth.gov/ghgcenter/img/icon-dot-gov.svg, I can see the icon 🤔

I thought this is already fixed via #1378, preview with the configuration for GHGC with the banner icons showing here: US-GHG-Center/veda-config-ghg#698

cc @slesaad

@snmln
Copy link
Contributor Author

snmln commented Jan 29, 2025

@dzole0311 The team was able to create a workaround prefixing the paths with /ghgcenter, which is what I believe we are seeing in the netlify preview currently.

@slesaad
Copy link
Member

slesaad commented Jan 29, 2025

The files do get copied, but there are two issues:

  1. like @snmln mentioned, we tried this workaround where we explicitly prefixed the path with /ghgcenter in here; but obviously that's not the best way to do it
  2. The workaround worked for the guidance icons, but didn't for the us flag icon (it was still referring to /img/... instead of /ghgcenter/img/..) probably because of the icon path is hardcoded here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Place in the backlog so we don't lose track tech debt
Projects
None yet
Development

No branches or pull requests

3 participants