Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Stories Hub does not update filters properly on URL change #1404

Open
vgeorge opened this issue Jan 27, 2025 · 1 comment · Fixed by #1405
Open

[Bug] Stories Hub does not update filters properly on URL change #1404

vgeorge opened this issue Jan 27, 2025 · 1 comment · Fixed by #1405
Labels
P2 Find a way to fix in the next few sprints

Comments

@vgeorge
Copy link
Contributor

vgeorge commented Jan 27, 2025

Context

On the Stories Hub page, the synchronization between the page URL query string and the UI elements is not working correctly. The following issues were observed:

  • Clicking on a card source updates the filtered cards, but not the dropdown
  • Clicking on a topic pill updates the URL, but neither the filtered cards nor the dropdown

I believe this issue is related to the use of onClick handlers to update the filters. We need to review the implementation of UseFiltersWithQueryResult to ensure that only URL changes trigger updates on the page elements for a more consistent user experience.

Related tickets: #1021

Blocking a release? No
Regression issue? Yes
Priority: TBD


Steps to reproduce the issue

  1. Visit http://localhost:9000/stories

  2. In the card list, click the "By Development Seed" source link on the second card

  3. In the card list, click on the "Agriculture" topic pill

  4. Visit the Agriculture topic URL directly:

  5. Visit the Development Seed source filter URL directly:

@vgeorge
Copy link
Contributor Author

vgeorge commented Jan 28, 2025

This was closed automatically by #1405, but it is not fixed yet and I reopened.

@vgeorge vgeorge added the P2 Find a way to fix in the next few sprints label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Find a way to fix in the next few sprints
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant