Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should see the same layout with "Today" when they select specific date #50

Closed
wcchung opened this issue Aug 17, 2020 · 6 comments
Closed

Comments

@wcchung
Copy link

wcchung commented Aug 17, 2020

Steps to Reproduce

  1. User upload record to LogBoard (with Today's data)
    test data: https://logboard-qa.numbersprotocol.io/d9034e81-e31c-4454-a390-a117657760bc

Results
When user select "Today" (date: 2020/8/17), they see
螢幕快照 2020-08-17 下午4 54 53

Then user select to specific date (date: 2020/8/17) in calendar, they see
螢幕快照 2020-08-17 下午4 59 28

  • Expected:
    User should see the same layout for specific date (2020/8/17) as they view the data "Today"

  • Actual:
    User see different layout for the exactly the same record but different manipulation.

Logs

Environment

  • mylog14-dashboard: v0.5.2-beta5
@CS6
Copy link
Contributor

CS6 commented Aug 18, 2020

原因:
目前的API主要有2組
api/v1/records/summary/?uid=UUID&template=heartFailure&start_date=2020-07-15&end_date=2020-07-24;`

api/v1/records/past-days/?uid=UUID&template=heartFailure&range=this-month

當是期選擇器 選取單日時
api/v1/records/summary/?uid=UUID&template=heartFailure&start_date=2020-08-18&end_date=2020-08-18;只會取道當日單筆資料 需要改用api/v1/records/past-days/?uid=UUID&template=heartFailure&range=today`
但是當日期不為當日就無法了 (目前的解法,我看了超久才發現QQ,一直以為是bug)

可能需要將條件改為 日期 (CC @shc261392 )
api/v1/records/past-days/?uid=UUID&template=heartFailure&range=2020-08-18

@scott-dt
Copy link

scott-dt commented Aug 19, 2020

v0.1.6

  1. 用左上方日期區間點選 (2020/08/17) 非當日
  2. 無法顯示點選 (2020/08/17) 的紀錄 ,而是顯示當日(2020/08/19)的紀錄
    image

@wcchung
Copy link
Author

wcchung commented Aug 24, 2020

根據 Slack channel 上的討論,此 milestone 先不處理此 issue,移到 backlog

@wcchung wcchung modified the milestones: beta6, Backlog Aug 24, 2020
@wcchung wcchung modified the milestones: Backlog, RC1 Aug 27, 2020
@shc261392
Copy link
Contributor

@CS6

The /api/v1/records/summary API endpoint will return complete data of the day if start_date equals end_date.

Example: {{hostUrl}}/api/v1/records/summary?uid=33d30286-08d8-4744-9ab0-e4e2042e25fe&template=commonCold&start_date=2020-08-28&end_date=2020-08-28

@scott-dt
Copy link

scott-dt commented Sep 4, 2020

image
image

@scott-dt
Copy link

scott-dt commented Sep 4, 2020

200904 verified by scott

@scott-dt scott-dt closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants