Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenshots #542

Closed
PierreBrisorgueil opened this issue Aug 6, 2020 · 1 comment · Fixed by #545
Closed

Screenshots #542

PierreBrisorgueil opened this issue Aug 6, 2020 · 1 comment · Fixed by #545

Comments

@PierreBrisorgueil
Copy link
Contributor

PierreBrisorgueil commented Aug 6, 2020 •
edited
Loading

Describe the bug
Failed to execute the query on document screenshot, important for debugging at given steps

To Reproduce

LET doc = DOCUMENT('https://www.google.com', {
    driver: 'cdp',
    viewport: {
        width: 1920,
        height: 1080
    }
})


RETURN { data: SCREENSHOT(doc) }

Expected behavior
should work like

RETURN { data: SCREENSHOT('https://www.google.com) }

Desktop (please complete the following information):
MacOS or Linux last ferret release

Additional context
Related to #309
@PierreBrisorgueil PierreBrisorgueil mentioned this issue Aug 6, 2020
Closed
@Pangoraw Pangoraw mentioned this issue Aug 11, 2020
Merged
@PierreBrisorgueil
Copy link
Contributor Author

thx @Pangoraw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix SCREENSHOT() param type check Pangoraw/ferret
1 participant
@PierreBrisorgueil