Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows are referencing vulnerable actions #82

Closed
igibek opened this issue Jan 30, 2022 · 1 comment
Closed

Workflows are referencing vulnerable actions #82

igibek opened this issue Jan 30, 2022 · 1 comment
Labels
invalid This doesn't seem right

Comments

@igibek
Copy link

igibek commented Jan 30, 2022

Hello, there!

As part of the university research we are currently doing regarding the security of Github Actions, we noticed that one or many of the workflows that are part of this repository are referencing vulnerable versions of the third-party actions. As part of a disclosure process, we decided to open issues to notify GitHub Community.

Please note that there are could be some false positives in our methodology, thus not all of the open issues could be valid. If that is the case, please let us know, so that we can improve on our approach. You can contact me directly using an email: ikoishy [at] ncsu.edu

Thanks in advance

  1. The workflow ci.yml is referencing action gittools/actions/gitversion/setup using references v0.9.9. However this reference is missing the commit 90150b4 which may contain fix to the vulnerability.
  2. The workflow ci.yml is referencing action gittools/actions/gitversion/execute using references v0.9.9. However this reference is missing the commit 90150b4 which may contain fix to the vulnerability.

The vulnerability fix that is missing by actions' versions could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider updating the reference to the action.

If you end up updating the reference, please let us know. We need the stats for the paper :-)

@Molnix888
Copy link
Owner

Hi @igibek, sorry for replying with a delay. I delayed the reply specifically because after quick glance I realized that unfortunately (of fortunately, depending on the side) a false-positive. At the moment of your comment my pipelines were referencing version 0.9.11 of the mentioned actions and they were on that version for at least a couple of month. Moreover, before that they were referencing version 0.9.10 pretty much since its release, containing fixes for the mentioned CVEs.

Hope that helps :)
Good luck with your research!

@Molnix888 Molnix888 added the invalid This doesn't seem right label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants