Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Chinese translation disappear from the language list. #508

Open
myuki opened this issue Mar 14, 2021 · 4 comments
Open

Bug: Chinese translation disappear from the language list. #508

myuki opened this issue Mar 14, 2021 · 4 comments
Assignees
Labels
Bug Something isn't working Translation UI/UX Related to appearance of the app and flyout.

Comments

@myuki
Copy link
Contributor

myuki commented Mar 14, 2021

Describe the bug:

Chinese translation disappear from the language list in v0.9.1.

To Reproduce:
Steps to reproduce the behavior:

  1. Go to 'General'
  2. Click on 'Language'
  3. Scroll down

Screenshots:

Screenshot 2021-03-14 143712

OS Version:

  • Windows 10 Version: Windows 10 21H2

ModernFlyouts Version:

  • Version: v0.9.1

Additional context:

Though it disappears from the language list. It still can be set to use Chinese by change the system language and use system default as the language.

屏幕截图 2021-03-14 144016

It may relate to #250 in v0.9.1.

@myuki myuki added the Bug Something isn't working label Mar 14, 2021
@prakharb5 prakharb5 added UI/UX Related to appearance of the app and flyout. Translation labels Mar 17, 2021
@IllyaTheHath
Copy link

I found out that in .net6.0, the chinese cultures are changed. zh-CN and zh-TW are missing, but instead there are zh-Hans-* and zh-Hant-* cultures.
dotnet5.0:
image
dotnet6.0:
image

If we changed TargetFramework to .net5.0 and rebuild the app, the chinese cultures will show again.
image

I tried to change Strings.zh-CN.resx to Strings.zh-Hans-CN.resx to adapt the change of .net6.0, but it didn't help. I don't know if my way is wrong or dotnet is not yet fully implement those changes.

Maybe we should wait for dotnet for future information.

PS: this link may help: https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry

@myuki
Copy link
Contributor Author

myuki commented Apr 27, 2021

I find this issue has been solved in 0.9.3, but no PR been linked to this issue and the change log also not mentioned that. Accidentally fixed the issue? @Samuel12321

@Samuel12321
Copy link
Member

In this release just to test things I included zh-cn/tw and hans/hant.
Just out of curiosity, which did it default to and what does it display in the list?

@IllyaTheHath
Copy link

Just zh-hans/hant in the list, no zh-cn/tw. It displayd in chinese but I dont know if it uses zh-cn or zh-hans. @Samuel12321
image

This was referenced Oct 7, 2021
@Samuel12321 Samuel12321 mentioned this issue Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Translation UI/UX Related to appearance of the app and flyout.
Projects
None yet
Development

No branches or pull requests

5 participants