Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitivity to scale #4

Open
sbysiak opened this issue Oct 15, 2020 · 1 comment
Open

Sensitivity to scale #4

sbysiak opened this issue Oct 15, 2020 · 1 comment

Comments

@sbysiak
Copy link

sbysiak commented Oct 15, 2020

Thank you for the package!
The vivo score seems to be sensitive to scale of the features due to computing just the area under partial dependence plot while the x-axis may vary by orders of magnitude for various features.
I think it could be first standarized (at least as an option), otherwise the features with large difference between min and max value are always preferred, as can be seen e.g. in http://docs.mlinpl.org/conference/2019/posters/AnnaKozak.pdf

@kozaka93
Copy link
Member

Thank you for the issue. In the first version, it was like that. Now we use weights based on empirical density or we average. Please check the density parameter in the latest version 0.2.1 available on CRAN and GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants