Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex: missing_stop_times_record #1820

Closed
emmambd opened this issue Sep 9, 2024 · 2 comments · Fixed by #1945
Closed

Flex: missing_stop_times_record #1820

emmambd opened this issue Sep 9, 2024 · 2 comments · Fixed by #1945
Assignees
Labels
flex Rules and rule changes related to GTFS-Flex. new rule New rule to be added status: Needs triage Applied to all new issues

Comments

@emmambd
Copy link
Contributor

emmambd commented Sep 9, 2024

Describe the problem

See below

Describe the new validation rule

missing_stop_times_record as defined in the table here

Sample GTFS datasets

No response

Severity

Error

Additional context

No response

@emmambd emmambd added status: Needs triage Applied to all new issues new rule New rule to be added labels Sep 9, 2024
@emmambd emmambd added this to the 7.0 Validator Release milestone Sep 9, 2024
@emmambd emmambd added the flex Rules and rule changes related to GTFS-Flex. label Dec 2, 2024
@qcdyx qcdyx self-assigned this Jan 15, 2025
@qcdyx
Copy link
Contributor

qcdyx commented Jan 16, 2025

@emmambd Does the following description of missing_stop_time_record notice look good to you?
Only 1 stop_times.txt record for the associated trip when
stop_times.start_pickup_dropoff_window and stop_times.end_pickup_dropoff_window are
defined, andstop_times.pickup_type and stop_times.drop_off_type are both set to 2
(MUST_PHONE), and there is only one record in stop_times.txt for the associated trip.

@emmambd
Copy link
Contributor Author

emmambd commented Jan 17, 2025

@qcdyx I think we can reduce confusion here by referencing the original spec language

Only one stop_times record is found where two are required. Travel within the same location group or GeoJSON location requires two records in stop_times.txt with the same location_group_id or location_id.

@qcdyx qcdyx linked a pull request Jan 22, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flex Rules and rule changes related to GTFS-Flex. new rule New rule to be added status: Needs triage Applied to all new issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants